-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add additional printer columns for ResourceGroup CRD #38
Conversation
This commit adds additional printer columns to the ResourceGroup instance CRDs, which will be displayed when listing ResourceGroup instances using `kubectl get` command. The additional columns are: - `State`: The current state of the ResourceGroup instance. Found in `.status.state` - Synced: Whether all subresources of the ResourceGroup are ready. Found in `status.conditions[?(@.type==\"InstanceSynced\")].status` - Age: The age of the ResourceGroup instance. Found in `.metadata.creationTimestamp`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This commit adds additional printer columns to the ResourceGroup instance CRDs, which will be displayed when listing ResourceGroup instances using `kubectl get` command. The additional columns are: - `State`: The current state of the ResourceGroup instance. Found in `.status.state` - Synced: Whether all subresources of the ResourceGroup are ready. Found in `status.conditions[?(@.type==\"InstanceSynced\")].status` - Age: The age of the ResourceGroup instance. Found in `.metadata.creationTimestamp` Sample kubectl output: ```bash ➜ ~ k get eksclusters NAME STATE SYNCED AGE testcluster29 ACTIVE True 22d ``` By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
This commit adds additional printer columns to the ResourceGroup instance CRDs, which will be displayed when listing ResourceGroup instances using `kubectl get` command. The additional columns are: - `State`: The current state of the ResourceGroup instance. Found in `.status.state` - Synced: Whether all subresources of the ResourceGroup are ready. Found in `status.conditions[?(@.type==\"InstanceSynced\")].status` - Age: The age of the ResourceGroup instance. Found in `.metadata.creationTimestamp` Sample kubectl output: ```bash ➜ ~ k get eksclusters NAME STATE SYNCED AGE testcluster29 ACTIVE True 22d ``` By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
This commit adds additional printer columns to the ResourceGroup instance CRDs, which will be displayed when listing ResourceGroup instances using `kubectl get` command. The additional columns are: - `State`: The current state of the ResourceGroup instance. Found in `.status.state` - Synced: Whether all subresources of the ResourceGroup are ready. Found in `status.conditions[?(@.type==\"InstanceSynced\")].status` - Age: The age of the ResourceGroup instance. Found in `.metadata.creationTimestamp` Sample kubectl output: ```bash ➜ ~ k get eksclusters NAME STATE SYNCED AGE testcluster29 ACTIVE True 22d ``` By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
This commit adds additional printer columns to the ResourceGroup
instance CRDs, which will be displayed when listing ResourceGroup
instances using
kubectl get
command. The additional columns are:State
: The current state of the ResourceGroup instance. Found in.status.state
Found in
status.conditions[?(@.type==\"InstanceSynced\")].status
.metadata.creationTimestamp
Sample kubectl output:
➜ ~ k get eksclusters NAME STATE SYNCED AGE testcluster29 ACTIVE True 22d
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.