Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add additional printer columns for ResourceGroup CRD #38

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

a-hilaly
Copy link
Member

This commit adds additional printer columns to the ResourceGroup
instance CRDs, which will be displayed when listing ResourceGroup
instances using kubectl get command. The additional columns are:

  • State: The current state of the ResourceGroup instance. Found in
    .status.state
  • Synced: Whether all subresources of the ResourceGroup are ready.
    Found in status.conditions[?(@.type==\"InstanceSynced\")].status
  • Age: The age of the ResourceGroup instance. Found in
    .metadata.creationTimestamp

Sample kubectl output:

~ k get eksclusters
NAME            STATE    SYNCED   AGE
testcluster29   ACTIVE   True     22d

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This commit adds additional printer columns to the ResourceGroup
instance CRDs, which will be displayed when listing ResourceGroup
instances using `kubectl get` command. The additional columns are:

- `State`: The current state of the ResourceGroup instance. Found in
  `.status.state`
- Synced: Whether all subresources of the ResourceGroup are ready.
  Found in `status.conditions[?(@.type==\"InstanceSynced\")].status`
- Age: The age of the ResourceGroup instance. Found in
  `.metadata.creationTimestamp`
@ack-prow ack-prow bot requested review from michaelhtm and TiberiuGC September 30, 2024 23:18
@ack-prow ack-prow bot added the approved label Sep 30, 2024
Copy link
Contributor

@michaelhtm michaelhtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added the lgtm label Sep 30, 2024
Copy link

ack-prow bot commented Sep 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [a-hilaly,michaelhtm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit 34d8702 into main Sep 30, 2024
3 checks passed
@a-hilaly a-hilaly deleted the a-hilaly/crd-printer-columns branch October 4, 2024 05:06
a-hilaly added a commit that referenced this pull request Nov 12, 2024
This commit adds additional printer columns to the ResourceGroup
instance CRDs, which will be displayed when listing ResourceGroup
instances using `kubectl get` command. The additional columns are:

- `State`: The current state of the ResourceGroup instance. Found in
  `.status.state`
- Synced: Whether all subresources of the ResourceGroup are ready.
  Found in `status.conditions[?(@.type==\"InstanceSynced\")].status`
- Age: The age of the ResourceGroup instance. Found in
  `.metadata.creationTimestamp`

Sample kubectl output:
```bash
➜  ~ k get eksclusters
NAME            STATE    SYNCED   AGE
testcluster29   ACTIVE   True     22d
```

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
a-hilaly added a commit that referenced this pull request Nov 12, 2024
This commit adds additional printer columns to the ResourceGroup
instance CRDs, which will be displayed when listing ResourceGroup
instances using `kubectl get` command. The additional columns are:

- `State`: The current state of the ResourceGroup instance. Found in
  `.status.state`
- Synced: Whether all subresources of the ResourceGroup are ready.
  Found in `status.conditions[?(@.type==\"InstanceSynced\")].status`
- Age: The age of the ResourceGroup instance. Found in
  `.metadata.creationTimestamp`

Sample kubectl output:
```bash
➜  ~ k get eksclusters
NAME            STATE    SYNCED   AGE
testcluster29   ACTIVE   True     22d
```

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
a-hilaly added a commit that referenced this pull request Nov 12, 2024
This commit adds additional printer columns to the ResourceGroup
instance CRDs, which will be displayed when listing ResourceGroup
instances using `kubectl get` command. The additional columns are:

- `State`: The current state of the ResourceGroup instance. Found in
  `.status.state`
- Synced: Whether all subresources of the ResourceGroup are ready.
  Found in `status.conditions[?(@.type==\"InstanceSynced\")].status`
- Age: The age of the ResourceGroup instance. Found in
  `.metadata.creationTimestamp`

Sample kubectl output:
```bash
➜  ~ k get eksclusters
NAME            STATE    SYNCED   AGE
testcluster29   ACTIVE   True     22d
```

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants