Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle x-kubernetes-preserve-unknown-fields #325

Merged
merged 10 commits into from
Feb 22, 2025
Merged

fix: handle x-kubernetes-preserve-unknown-fields #325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ae7bc7d
fix: handle missing type in schema when x-kubernetes-preserve-unknown…
johnknutsonhc Feb 20, 2025
82a5b92
fix: remove unused var
johnknutsonhc Feb 21, 2025
a6061d8
fix: remove debugging import
johnknutsonhc Feb 21, 2025
fb86fcd
chore: go fmt
johnknutsonhc Feb 21, 2025
f9310b2
fix: handle missing type in schema when x-kubernetes-preserve-unknown…
johnknutsonhc Feb 20, 2025
92d6af5
fix: remove unused var
johnknutsonhc Feb 21, 2025
b37e27a
fix: remove debugging import
johnknutsonhc Feb 21, 2025
88ba2db
chore: go fmt
johnknutsonhc Feb 21, 2025
4b9a898
Merge branch 'fix/x-kubernetes-preserve-unknown-fields' of https://gi…
johnknutsonhc Feb 21, 2025
1eb75b5
fix: remove debugging
jknutson Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pkg/graph/emulator/emulator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,11 @@ func (e *Emulator) generateValue(schema *spec.Schema) (interface{}, error) {
return nil, fmt.Errorf("schema is nil")
}

if enabled, ok := schema.VendorExtensible.Extensions["x-kubernetes-preserve-unknown-fields"]; ok && enabled.(bool) {
// Handle x-kubernetes-preserve-unknown-fields
return e.generateObject(schema)
}

if enabled, ok := schema.VendorExtensible.Extensions["x-kubernetes-int-or-string"]; ok && enabled.(bool) {
// Default to integer for dummy CRs
return e.generateInteger(schema), nil
Expand Down
18 changes: 18 additions & 0 deletions pkg/graph/emulator/emulator_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,6 +501,24 @@ func TestGenerateValueWithIntOrString(t *testing.T) {

}

func TestGenerateValueWithPreserveUnknownFields(t *testing.T) {
e := NewEmulator()

t.Run("x-kubernetes-preserve-unknown-fields present, does not produce error", func(t *testing.T) {
schema := &spec.Schema{
VendorExtensible: spec.VendorExtensible{
Extensions: map[string]interface{}{
"x-kubernetes-preserve-unknown-fields": true,
},
},
}

_, err := e.generateValue(schema)
require.NoError(t, err)
})

}

func ptr[T comparable](v T) *T {
return &v
}
Expand Down