feat: add go ldflags for version info injection #313
Conversation
This label is not really useful since pod IDs change in HA setups, making the label meaningless.
Add support for injecting version information at build time via ldflags. This includes: - Version, git commit hash, and build date injection in `.ko.yaml` - Updated metadata labeler to use dynamic version - Makefile updates to support version info injection
| $(KO) build --bare github.com/kro-run/kro/cmd/controller \ | ||
| --local\ | ||
| --push=false --tags ${RELEASE_VERSION} --sbom=none | ||
|
|
||
| .PHONY: publish | ||
| publish-image: ko ## Publish the kro controller images to ghcr.io | ||
| $(WITH_GOFLAGS) KOCACHE=$(KOCACHE) \ | ||
| $(WITH_GOFLAGS) KOCACHE=$(KOCACHE) KO_DOCKER_REPO=$(KO_DOCKER_REPO) \ |
There was a problem hiding this comment.
Is the fact the KO_DOCKER_REPO wasn't here before a bug?
| KroVersionLabel = LabelKroPrefix + "kro-version" | ||
| ControllerPodIDLabel = LabelKroPrefix + "controller-pod-id" | ||
| OwnedLabel = LabelKroPrefix + "owned" | ||
| KroVersionLabel = LabelKroPrefix + "kro-version" |
There was a problem hiding this comment.
I'm being a super pedant here but:
https://google.github.io/styleguide/go/decisions#initialisms
KRO vs Kro.
There was a problem hiding this comment.
This applies elsewhere in this file too.
| kroVersion string, | ||
| controllerPodID string, | ||
| ) GenericLabeler { | ||
| func NewKroMetaLabeler() GenericLabeler { |
There was a problem hiding this comment.
What's the experience when running tests locally (in a KIND cluster, for example).
Are the labels set correctly? I looked at the makefile and I think they will be?
What about in envtest (less sure they will be there)?
Does it make sense to have this still be settable on the labeller and then have the envtest context specifically pass "something"? Or maybe we need envtest contexts to just set pkg.Version/etc correctly?
Add support for injecting version information at build time via ldflags. This includes:
.ko.yaml