You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Observed Behavior:
When testing RGD creation and deletion using the following sample: example/kubernetes/webapp/rg.yaml, informers are successfully registered but fail to be cleaned up due to pkg\metadata\groupversion.go#GetResourceGraphDefinitionInstanceGVR returning an improperly formatted GVR. This finding also blocks #198 due to relying on the same gvr reference to deregister queues or gvrSets.
Expected Behavior:
Successfully deregister informers on DynamicController#StopServiceGVK
Reproduction Steps (Please include ResourceGraphDefinition and Instances files):
Apply examples\kubernetes\webapp\rg.yaml and delete it with a debugger in DynamicController#StopServiceGVK. We perform an early return after not finding the informer due to the name mismatch
Versions:
kro version: 0.2.1
Kubernetes Version (kubectl version): v1.30.2
Involved Controllers:
Controller URLs and Versions (if applicable): KRO RGD Controller passing GVR to Dynamic Controller
Error Logs (if applicable)**:
No logs, just early termination and no errors or warnings
Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment
Description
Observed Behavior:
When testing RGD creation and deletion using the following sample:
example/kubernetes/webapp/rg.yaml
, informers are successfully registered but fail to be cleaned up due topkg\metadata\groupversion.go#GetResourceGraphDefinitionInstanceGVR
returning an improperly formatted GVR. This finding also blocks #198 due to relying on the same gvr reference to deregister queues or gvrSets.Proposed GVR:
Expected Behavior:
Successfully deregister informers on
DynamicController#StopServiceGVK
Reproduction Steps (Please include
ResourceGraphDefinition
andInstances
files):Apply
examples\kubernetes\webapp\rg.yaml
and delete it with a debugger inDynamicController#StopServiceGVK
. We perform an early return after not finding the informer due to the name mismatchVersions:
kubectl version
): v1.30.2Involved Controllers:
Error Logs (if applicable)**:
No logs, just early termination and no errors or warnings
Which option describes the most your issue?
ResourceGraphDefinition (Create, Update, Deletion)
The text was updated successfully, but these errors were encountered: