Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improper GVR formatting causing failed informer deregistration #305

Closed
Gonfidel opened this issue Feb 15, 2025 · 0 comments · Fixed by #306
Closed

Improper GVR formatting causing failed informer deregistration #305

Gonfidel opened this issue Feb 15, 2025 · 0 comments · Fixed by #306
Labels
kind/bug Something isn't working

Comments

@Gonfidel
Copy link
Contributor

Description

Observed Behavior:
When testing RGD creation and deletion using the following sample: example/kubernetes/webapp/rg.yaml, informers are successfully registered but fail to be cleaned up due to pkg\metadata\groupversion.go#GetResourceGraphDefinitionInstanceGVR returning an improperly formatted GVR. This finding also blocks #198 due to relying on the same gvr reference to deregister queues or gvrSets.

Proposed GVR:

schema.GroupVersionResource{
-		Group:    fmt.Sprintf("%s.%s", pluralKind, group),
+		Group:    group,
		Version:  apiVersion,
		Resource: pluralKind,
	}

Expected Behavior:
Successfully deregister informers on DynamicController#StopServiceGVK

Reproduction Steps (Please include ResourceGraphDefinition and Instances files):
Apply examples\kubernetes\webapp\rg.yaml and delete it with a debugger in DynamicController#StopServiceGVK. We perform an early return after not finding the informer due to the name mismatch

Versions:

  • kro version: 0.2.1
  • Kubernetes Version (kubectl version): v1.30.2

Involved Controllers:

  • Controller URLs and Versions (if applicable): KRO RGD Controller passing GVR to Dynamic Controller

Error Logs (if applicable)**:
No logs, just early termination and no errors or warnings

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Which option describes the most your issue?

ResourceGraphDefinition (Create, Update, Deletion)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant