Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

track ResourceGroup changes and opt-in updates #188

Open
a-hilaly opened this issue Jan 9, 2025 · 0 comments
Open

track ResourceGroup changes and opt-in updates #188

a-hilaly opened this issue Jan 9, 2025 · 0 comments
Assignees

Comments

@a-hilaly
Copy link
Member

a-hilaly commented Jan 9, 2025

Feature Description

Currently instances don't track which version of their parent ResourceGroup they were created from. we need to add support for tracking ResourceGroup generation and resourceRevision (not sure about the revision) in instance status, and require an annotation (kro.run/allow-updates: "true") for instances to receive updates from their parent ResourceGroup. This prevents unexpected changes to running instances when ResourceGroups are modified.

Example:

apiVersion: kro.run/v1alpha1
kind: Application
metadata:
  name: my-application
  annotations:
    kro.run/allow-updates: "true"  # Required to receive parent RG changes
spec:
  name: my-app
  image: nginx
status:
  resourceGroupGeneration: 123  # Track parent RG's metadata.generation
  resourceRevision: abc123           # Track parent RG's spec hash/revision
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants