support bundle execution on macos #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took some notes from #13 and applied further changes until I got an ansible playbook bundle running in a GitHub actions runner with macos-latest.
Does not include additions such as brew in order to be able to develop this repository on macos. I don't have such a system available to make that work.
Notable code changes that were necessary.
The
realpathbinary is not installed by default on macos, and I guess it could cause issues where symlinks are involved (or was there another issue which realpath fixed), but I would expect pip to be able to deal with symlinks.The PIP binary path is different on macos, and set an additional path in regards to that (the macos-latest runner had Python 3.12.7, but the bin path only includes the major.minor versions without the patch level).