Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support base64-1.0 #557

Closed
wants to merge 1 commit into from
Closed

Support base64-1.0 #557

wants to merge 1 commit into from

Conversation

tomjaguarpaw
Copy link
Collaborator

I'd really rather not do this. I'd rather extractBase64 be added to the base64-0.4 so we can write code that works across both versions, but if we can't persuade the maintainer to do that we can fall back to this.

@tomjaguarpaw tomjaguarpaw requested a review from vrom911 as a code owner February 5, 2024 11:48
@tomjaguarpaw
Copy link
Collaborator Author

Requested that base64 add the compatibility layer itself in emilypi/base64#59

@tomjaguarpaw
Copy link
Collaborator Author

tomjaguarpaw commented Feb 5, 2024 •
edited
Loading

I'm going to include #557 in here, since we might as well support the bumped clay and base64 at the same time. Oops, wrong thread.

@tomjaguarpaw tomjaguarpaw mentioned this pull request Feb 5, 2024
Merged
@tomjaguarpaw
Copy link
Collaborator Author

Closing in favour of #559

@tomjaguarpaw tomjaguarpaw deleted the base64 branch February 5, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrom911 vrom911 Awaiting requested review from vrom911 vrom911 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tomjaguarpaw