-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
y-axis coordinates and x-axis coordinates are the same #18
Comments
Thanks for your efforts to develop this package @koustav-pal We've replicated this issue (@kuguit and I) when plotting trans-chromosomal contacts between chromosomes of different sizes (x-axes chromosome was smaller than y-axes). The y_coords therefore did not match the axes limits defined by x_coords or the maximum length of the shorter chromosome.
I've found the bug causing this and have a working solution which allows:
I've tested this solution by modifying the function code and running "source" on this R script to import the update version. I'll submit a pull request with recommended changes. |
I think this solution will resolve issue #17 as well. |
verbose solution to koustav-pal#17 and koustav-pal#18
I've added these as 2 separate PRs as #25 directly addresses this issue while #26 significantly changes the codebase to allow transpose matrices in the lower triangle to be plotted.
|
A potential problem here. When x_coords and y_coords are not the same, y_axis inherits axis labels and values from x_axis. Refer, line 222 - 235 in Brick_vizart_plot_heatmap.
The text was updated successfully, but these errors were encountered: