Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

y-axis coordinates and x-axis coordinates are the same #18

Open
koustav-pal opened this issue Jun 17, 2020 · 3 comments
Open

y-axis coordinates and x-axis coordinates are the same #18

koustav-pal opened this issue Jun 17, 2020 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@koustav-pal
Copy link
Owner

A potential problem here. When x_coords and y_coords are not the same, y_axis inherits axis labels and values from x_axis. Refer, line 222 - 235 in Brick_vizart_plot_heatmap.

@koustav-pal koustav-pal added the bug Something isn't working label Jun 17, 2020
@koustav-pal koustav-pal self-assigned this Jun 17, 2020
@Kelly-ST-HRI
Copy link

Thanks for your efforts to develop this package @koustav-pal

We've replicated this issue (@kuguit and I) when plotting trans-chromosomal contacts between chromosomes of different sizes (x-axes chromosome was smaller than y-axes). The y_coords therefore did not match the axes limits defined by x_coords or the maximum length of the shorter chromosome.

Error in h(simpleError(msg, call)) :
error in evaluating the argument 'x' in selecting a method for function 'end': subscript contains out-of-bounds indices

I've found the bug causing this and have a working solution which allows:

  • different co-ordinate inputs for each chromosome
  • plotting asymmetric matrices which axes of different sizes
  • inverting the matrix to (optionally) allow plotting the larger chromosome on the x-axis from the same "brick" file

I've tested this solution by modifying the function code and running "source" on this R script to import the update version. I'll submit a pull request with recommended changes.

@Kelly-ST-HRI
Copy link

I think this solution will resolve issue #17 as well.

@Kelly-ST-HRI
Copy link

I've added these as 2 separate PRs as #25 directly addresses this issue while #26 significantly changes the codebase to allow transpose matrices in the lower triangle to be plotted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants