Skip to content

Refactor goroutines to improve readability #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

arstanaly
Copy link
Contributor

Refactor go routines in the CLI code to improve code readability and simplify error handling in the routines.

@arstanaly arstanaly force-pushed the refactor-goroutines-use branch 2 times, most recently from aec1f61 to 72b4ee8 Compare February 15, 2025 20:30
@arstanaly arstanaly force-pushed the refactor-goroutines-use branch from 72b4ee8 to 37a4daf Compare February 15, 2025 20:32
@arstanaly
Copy link
Contributor Author

Hey, @sami-alajrami 👋
A small refactoring of go routines from me 😄
Could you please approve the workflow run for this PR? I would like to see if tests are still passing

@sami-alajrami
Copy link
Contributor

Hey, @sami-alajrami 👋 A small refactoring of go routines from me 😄 Could you please approve the workflow run for this PR? I would like to see if tests are still passing

Hey @arstanaly , thanks for the PR, the CI run is now approved

@sami-alajrami
Copy link
Contributor

Hey @arstanaly , thanks for the PR, the CI run is now approved

CI is failing because env vars and secrets are not passed to the build from your branch and it does not seem Github gives an option to share those. Maybe the quickest way to progress on this for now is that I replicate your PR which you can then edit.

@arstanaly
Copy link
Contributor Author

Hey @arstanaly , thanks for the PR, the CI run is now approved

CI is failing because env vars and secrets are not passed to the build from your branch and it does not seem Github gives an option to share those. Maybe the quickest way to progress on this for now is that I replicate your PR which you can then edit.

I see, thanks for checking this. I will try to add unit tests with HTTP mocks for these to improve feedback loop.
But it is a bit frustrating that it's hard to test CLI if one doesn't have write permissions to the repo 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants