Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy comments #2

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Tidy comments #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/gcloud.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ use std::{process::Stdio, str};
use tokio::process::{self, Child};

pub trait GcloudCommand {
// I may recall something about a command trait.. could be useful here
fn new() -> process::Command;
}

Expand All @@ -15,7 +14,6 @@ impl GcloudCommand for Gcloud {
}

pub fn is_authed() -> bool {
// @simon this is wrong, it does not fail when not authenticated
std::process::Command::new("gcloud")
.args(["projects", "list"])
.stdout(Stdio::piped())
Expand Down
1 change: 0 additions & 1 deletion src/stream.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ use tokio_stream::{wrappers::LinesStream, StreamExt};
use crate::log::Log;

pub async fn transpose<F>(
// TODO: perhaps could be an AsycnStream, iirc tokio exposes stdout as an async stream
mut writer: impl std::io::Write,
reader: impl AsyncBufRead + Unpin,
) -> std::io::Result<()>
Expand Down
Loading