From 63454e336c1ed993beb254772d7280a1e303e67d Mon Sep 17 00:00:00 2001 From: Simon Madine Date: Tue, 7 Jan 2025 13:55:42 +0000 Subject: [PATCH] Tidy comments --- src/gcloud.rs | 2 -- src/stream.rs | 1 - 2 files changed, 3 deletions(-) diff --git a/src/gcloud.rs b/src/gcloud.rs index 5f02ab5..66ee75f 100644 --- a/src/gcloud.rs +++ b/src/gcloud.rs @@ -3,7 +3,6 @@ use std::{process::Stdio, str}; use tokio::process::{self, Child}; pub trait GcloudCommand { - // I may recall something about a command trait.. could be useful here fn new() -> process::Command; } @@ -15,7 +14,6 @@ impl GcloudCommand for Gcloud { } pub fn is_authed() -> bool { - // @simon this is wrong, it does not fail when not authenticated std::process::Command::new("gcloud") .args(["projects", "list"]) .stdout(Stdio::piped()) diff --git a/src/stream.rs b/src/stream.rs index 2778efd..df27636 100644 --- a/src/stream.rs +++ b/src/stream.rs @@ -4,7 +4,6 @@ use tokio_stream::{wrappers::LinesStream, StreamExt}; use crate::log::Log; pub async fn transpose( - // TODO: perhaps could be an AsycnStream, iirc tokio exposes stdout as an async stream mut writer: impl std::io::Write, reader: impl AsyncBufRead + Unpin, ) -> std::io::Result<()>