Skip to content

Commit

Permalink
Merge pull request #2 from komment-ai/tidy-comments
Browse files Browse the repository at this point in the history
Tidy comments
  • Loading branch information
thingsinjars authored Jan 7, 2025
2 parents 51e9e98 + 63454e3 commit 1ef4e56
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 3 deletions.
2 changes: 0 additions & 2 deletions src/gcloud.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ use std::{process::Stdio, str};
use tokio::process::{self, Child};

pub trait GcloudCommand {
// I may recall something about a command trait.. could be useful here
fn new() -> process::Command;
}

Expand All @@ -15,7 +14,6 @@ impl GcloudCommand for Gcloud {
}

pub fn is_authed() -> bool {
// @simon this is wrong, it does not fail when not authenticated
std::process::Command::new("gcloud")
.args(["projects", "list"])
.stdout(Stdio::piped())
Expand Down
1 change: 0 additions & 1 deletion src/stream.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ use tokio_stream::{wrappers::LinesStream, StreamExt};
use crate::log::Log;

pub async fn transpose<F>(
// TODO: perhaps could be an AsycnStream, iirc tokio exposes stdout as an async stream
mut writer: impl std::io::Write,
reader: impl AsyncBufRead + Unpin,
) -> std::io::Result<()>
Expand Down

0 comments on commit 1ef4e56

Please sign in to comment.