more comments

kolide · Apr 12, 2024 · a324923 · a324923
1 parent 47e3fc0
commit a324923
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 4 deletions.
diff --git a/boxer.go b/boxer.go
@@ -170,7 +170,6 @@ func (boxer boxMaker) DecodeUnverified(b64 string) (*Box, error) {
 		return nil, fmt.Errorf("decoding base64: %w", err)
 	}
 
-	// Limit size to prevent garbage from filling memory
 	if len(data) > V0MaxSize {
 		return nil, fmt.Errorf("data too big, is %d, max is %d", len(data), V0MaxSize)
 	}
@@ -202,7 +201,6 @@ func (boxer boxMaker) DecodePngUnverified(r io.Reader) (*Box, error) {
 		return nil, fmt.Errorf("decoding png: %w", err)
 	}
 
-	// Limit size to prevent garbage from filling memory
 	if data.Len() > V0MaxSize {
 		return nil, errors.New("looks to be larger than max box size")
 	}
@@ -211,7 +209,6 @@ func (boxer boxMaker) DecodePngUnverified(r io.Reader) (*Box, error) {
 }
 
 func (boxer boxMaker) DecodeRaw(data []byte) (*Box, error) {
-	// Limit size to prevent garbage from filling memory
 	if len(data) > V0MaxSize {
 		return nil, fmt.Errorf("data too big, is %d, max is %d", len(data), V0MaxSize)
 	}

diff --git a/pkg/challenge/response.go b/pkg/challenge/response.go
@@ -84,7 +84,6 @@ type InnerResponse struct {
 }
 
 func UnmarshalResponse(outerResponseBytes []byte) (*OuterResponse, error) {
-	// Limit size to prevent garbage from filling memory
 	if len(outerResponseBytes) > krypto.V0MaxSize {
 		return nil, fmt.Errorf("response to large: is %d, max is %d", len(outerResponseBytes), krypto.V0MaxSize)
 	}