-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inverse of "disableStream" should also exist #423
Comments
Could you clarify, if it's possible to disable all streams but 1 using ffmpeg CLI? |
@kokorin lets say: My Stream has: Video, Audio, Subtitles, and maybe at random attachments/Data. In other words the nice design philosophy you try to provide falls apart because you have to explicit. or to simplify the request: public Input disableAllStreams(); //Disables all streams
public Input enableStream(StreamType type); //Enables the requested stream
public Input onlyEnableStream(StreamType type); //Disables all BUT the requested stream. |
Could you answer my question? |
@kokorin yes, how else would you extract audio files from video+audio files or extract subtitles from the three combo. This is the video specific documentation, it also exists for Subtitles and Audio, Data, Attachment option.
Here is the stream selection doc:
|
With ffmpeg CLI it possible to disable stream types on by one, Jaffree allows the same. It possible to add a method to disable several stream types (not just 1). Pay attention that ffmpeg has 2 types of video streams: Unfortunately ATM I have not much free time to work on this feature request, please feel free to suggest a PR. |
@kokorin I know you don't have much time. Unfortunately it would require me to switch IDEs to fulfill your PR requirements, which i am not willing to do. And since the other two PRs are in effective limbo, (since i won't fulfill them by blindly guessing what the logs could mean, or you wouldn't allow the closing of them) i am going to refrain from issuing PRs. Otherwise these would have been PRs in the first place and not Issues. |
@kokorin even so the plugin is already 2 years outdated it didn't crash the IDE yet... (Foreshadowing) I applied your style on to it and tested it with the "Process Listener" which resulted in my class having 0 mistakes. (made a screenshot but can't upload it by the time of writing will be explained later) Then i tried switching to the other project and applied checkstyle. 3 seconds later my mouse froze. (That's why i can't right now upload the image because that is mouse only, technically you can open the window for image upload but traverse this using just the keyboard is to much pain) Anyways uninstalling this plugin because it causes issues with windows itself... As i said i am willing to do 90% of the work required to fulfil your checkstyle but odly specific things on how you want things to do is something I ask you to quick fix yourself since I can't. Oh yeah also sorry for the typos. Spell checking is kinda mouse bound too... |
Describe the issue
If you want to filter out only 1 stream source and ignore everything else then you have to forloop over everything else.
Or make a helper function for that specifically. But once a stream is blacklisted you can't get rid of it either.
It would be nice if you had a option to say: "Only these should be allowed" or a "ignore all" and a "remove from Ignore list".
QoL stuff after all.
The text was updated successfully, but these errors were encountered: