disable warnings in third-party code

[cwpearson]

This is third-party code, so modify the compiler flags instead of the code itself.

[cwpearson]

-Wno-error=redundant-move was introduced in GCC 9.1 and Clang 3.7

[dalg24]

If anything we should disable all warnings.
On my cell now but I am sure you can find examples of us doing that, possibly for gtest in core?

[dalg24]

If anything we should disable all warnings.
On my cell now but I am sure you can find examples of us doing that, possibly for gtest in core?

We do it in perf_test for google benchmark. Sorry can't get a reference but I am sure you'll find it

[cwpearson]

Cool, TIL about -w / /w.

Changed perfetto.cc to be compiled into its own static library so we still get warnings from our connector code.

[masterleinad]

Why do we built the library explicitly as static with fpic instead of shared?

[cwpearson]

I figured it was less opportunity for something to go wrong during the build. I don't have a strong opinion.

[masterleinad]

Changed perfetto.cc to be compiled into its own static library so we still get warnings from our connector code.

Can you elaborate on that?

[cwpearson]

Used to be that our connector code (libperfetto-connector.cc) and the third-party perfetto.cc were compiled into the same target, so whatever options were applied to one would be applied to both. I split them up so we could ignore warnings from perfetto.cc and otherwise leave our code compiling the way it used to be.

[masterleinad]

Fine with me.

[cwpearson]

I don't have the merge power, someone else will have to hit the button

[masterleinad]

I don't have the merge power, someone else will have to hit the button

Probably only @dalg24 and @crtrott.