Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: timeout on fxart metadata #265

Closed
wants to merge 1 commit into from
Closed

Conversation

preschian
Copy link
Member

@preschian preschian commented Apr 6, 2024

Fix #264

From logs, it was timeout. Lets increase the timeout?

Screenshot 2024-04-06 at 16 08 55

@preschian preschian marked this pull request as ready for review April 6, 2024 09:10
@preschian preschian requested a review from vikiival April 6, 2024 09:10
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will have very negative consequences on performance as it loops many times

@preschian
Copy link
Member Author

this will have very negative consequences on performance as it loops many times

Which loops is that?

By default, $obtain has three retries, right? this changes it to 6 and delays 10s each retry. It is similar to having a 60s timeout.

@vikiival
Copy link
Member

vikiival commented Apr 6, 2024

it is similar to having a 60s timeout.

So in the end it adds + 30sec per interaction per user

@preschian
Copy link
Member Author

So in the end it adds + 30sec per interaction per user

Any idea then how to fix the timeout request?

Because, from 70~ items in collection "115", it only affected the "retry" request on these items, not on "every" item

Capture-2024-04-06-203440

@vikiival
Copy link
Member

vikiival commented Apr 6, 2024

I wrote PoC with deno

Screenshot 2024-04-06 at 16 43 06

18 ms response

prob the metadata url is veery slow ^-^ can help you to optimize that

@preschian
Copy link
Member Author

preschian commented Apr 6, 2024

imo that's different topic

anyway, in your poc, sn was directly return. try to hit a round trip to the indexer to find the nft index

it's not about workers vs deno, tho

@preschian
Copy link
Member Author

Because, from 70~ items in collection "115", it only affected the "retry" request on these items, not on "every" item

based on this
7 items timeout
rest of the items success

so, not all every items will fetch slow requests

@vikiival
Copy link
Member

In the meantime we have a ton of other solutions

  • reworked your solution

@vikiival vikiival closed this Apr 17, 2024
@preschian preschian deleted the fix-timeout branch April 17, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants