Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance attribute calc on mass mint #11374

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Feature

Needs Design check

Needs QA check

  • @kodadot/qa-guild please review

Context

  • Continue after Enhanced Bulk Minting: Enable Rarity Calculation Based on Attributes #11152
  • During massmint, calc attributes rarity based on existing nfts on the current collection.
    Before: the attributes rarity result is based on the all the nfts in the massmint process
    After: the attributes rarity result will be based on all the nfts in the massmint and also the existing nfts on the current collection.

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
image

Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 9193b4f
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6792401a2e01a500081e2f63
😎 Deploy Preview https://deploy-preview-11374--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Jarsen136 Jarsen136 marked this pull request as ready for review January 23, 2025 13:11
@Jarsen136 Jarsen136 requested a review from a team as a code owner January 23, 2025 13:11
@Jarsen136 Jarsen136 requested review from vikiival and hassnian and removed request for a team January 23, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant