Use pointers for request/response structs instead of values in genera…

…ting methods (#33)


Signed-off-by: Dmitry Volodin <dmvolod@gmail.com>

examples/helloworld/main.go

@@ -33,7 +33,7 @@ func run() error {
 	}
 	defer eveningPlugin.Close(ctx)
 
-	reply, err := morningPlugin.Greet(ctx, greeting.GreetRequest{
+	reply, err := morningPlugin.Greet(ctx, &greeting.GreetRequest{
 		Name: "go-plugin",
 	})
 	if err != nil {
@@ -42,7 +42,7 @@ func run() error {
 
 	fmt.Println(reply.GetMessage())
 
-	reply, err = eveningPlugin.Greet(ctx, greeting.GreetRequest{
+	reply, err = eveningPlugin.Greet(ctx, &greeting.GreetRequest{
 		Name: "go-plugin",
 	})
 	if err != nil {

examples/helloworld/plugin-evening/evening.go

@@ -18,8 +18,8 @@ type GoodEvening struct{}
 
 var _ greeting.Greeter = (*GoodEvening)(nil)
 
-func (m GoodEvening) Greet(_ context.Context, request greeting.GreetRequest) (greeting.GreetReply, error) {
-	return greeting.GreetReply{
+func (m GoodEvening) Greet(_ context.Context, request *greeting.GreetRequest) (*greeting.GreetReply, error) {
+	return &greeting.GreetReply{
 		Message: fmt.Sprintf("Good evening, %s", request.GetName()),
 	}, nil
 }

examples/helloworld/plugin-morning/morning.go

@@ -17,8 +17,8 @@ type GoodMorning struct{}
 
 var _ greeting.Greeter = (*GoodMorning)(nil)
 
-func (m GoodMorning) Greet(ctx context.Context, request greeting.GreetRequest) (greeting.GreetReply, error) {
-	return greeting.GreetReply{
+func (m GoodMorning) Greet(_ context.Context, request *greeting.GreetRequest) (*greeting.GreetReply, error) {
+	return &greeting.GreetReply{
 		Message: "Good morning, " + request.GetName(),
 	}, nil
 }

examples/host-functions/main.go

@@ -31,7 +31,7 @@ func run() error {
 	}
 	defer greetingPlugin.Close(ctx)
 
-	reply, err := greetingPlugin.Greet(ctx, greeting.GreetRequest{
+	reply, err := greetingPlugin.Greet(ctx, &greeting.GreetRequest{
 		Name: "go-plugin",
 	})
 	if err != nil {
@@ -49,24 +49,24 @@ type myHostFunctions struct{}
 var _ greeting.HostFunctions = (*myHostFunctions)(nil)
 
 // HttpGet is embedded into the plugin and can be called by the plugin.
-func (myHostFunctions) HttpGet(ctx context.Context, request greeting.HttpGetRequest) (greeting.HttpGetResponse, error) {
+func (myHostFunctions) HttpGet(_ context.Context, request *greeting.HttpGetRequest) (*greeting.HttpGetResponse, error) {
 	resp, err := http.Get(request.Url)
 	if err != nil {
-		return greeting.HttpGetResponse{}, err
+		return nil, err
 	}
 	defer resp.Body.Close()
 
 	buf, err := io.ReadAll(resp.Body)
 	if err != nil {
-		return greeting.HttpGetResponse{}, err
+		return nil, err
 	}
 
-	return greeting.HttpGetResponse{Response: buf}, nil
+	return &greeting.HttpGetResponse{Response: buf}, nil
 }
 
 // Log is embedded into the plugin and can be called by the plugin.
-func (myHostFunctions) Log(ctx context.Context, request greeting.LogRequest) (emptypb.Empty, error) {
+func (myHostFunctions) Log(_ context.Context, request *greeting.LogRequest) (*emptypb.Empty, error) {
 	// Use the host logger
 	log.Println(request.GetMessage())
-	return emptypb.Empty{}, nil
+	return &emptypb.Empty{}, nil
 }

examples/host-functions/plugin/plugin.go

@@ -17,21 +17,21 @@ type GreetingPlugin struct{}
 
 var _ greeting.Greeter = (*GreetingPlugin)(nil)
 
-func (m GreetingPlugin) Greet(ctx context.Context, request greeting.GreetRequest) (greeting.GreetReply, error) {
+func (m GreetingPlugin) Greet(ctx context.Context, request *greeting.GreetRequest) (*greeting.GreetReply, error) {
 	hostFunctions := greeting.NewHostFunctions()
 
 	// Logging via the host function
-	hostFunctions.Log(ctx, greeting.LogRequest{
+	hostFunctions.Log(ctx, &greeting.LogRequest{
 		Message: "Sending a HTTP request...",
 	})
 
 	// HTTP GET via the host function
-	resp, err := hostFunctions.HttpGet(ctx, greeting.HttpGetRequest{Url: "http://ifconfig.me"})
+	resp, err := hostFunctions.HttpGet(ctx, &greeting.HttpGetRequest{Url: "http://ifconfig.me"})
 	if err != nil {
-		return greeting.GreetReply{}, err
+		return nil, err
 	}
 
-	return greeting.GreetReply{
+	return &greeting.GreetReply{
 		Message: "Hello, " + request.GetName() + " from " + string(resp.Response),
 	}, nil
 }