Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new job to run internal encryption tests for Contour #3649

Merged

Conversation

KauzClay
Copy link
Contributor

@KauzClay KauzClay commented Dec 16, 2022

What this PR does, why we need it:

@knative-prow
Copy link

knative-prow bot commented Dec 16, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 16, 2022
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 16, 2022
@krsna-m
Copy link
Contributor

krsna-m commented Dec 16, 2022

@KauzClay Looks like update-codegen script needs to be ran. The prow job_config yaml is just a template the codegen tool will generate the actual job yaml

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 16, 2022
@krsna-m
Copy link
Contributor

krsna-m commented Dec 19, 2022

/approve

@knative-prow
Copy link

knative-prow bot commented Dec 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KauzClay, kvmware

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2022
@KauzClay KauzClay marked this pull request as ready for review January 11, 2023 19:28
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 11, 2023
@knative-prow knative-prow bot requested a review from chaodaiG January 11, 2023 19:28
@KauzClay KauzClay marked this pull request as draft January 11, 2023 20:28
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 11, 2023
@KauzClay KauzClay marked this pull request as ready for review January 12, 2023 17:36
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 12, 2023
@knative-prow knative-prow bot requested a review from psschwei January 12, 2023 17:36
@krsna-m
Copy link
Contributor

krsna-m commented Jan 12, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2023
@knative-prow knative-prow bot merged commit 71d8478 into knative:main Jan 12, 2023
@knative-prow
Copy link

knative-prow bot commented Jan 12, 2023

@KauzClay: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key serving-main.gen.yaml using file prow/jobs/generated/knative/serving-main.gen.yaml

In response to this:

What this PR does, why we need it:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

KauzClay added a commit to KauzClay/test-infra that referenced this pull request Jan 30, 2023
knative-prow bot pushed a commit that referenced this pull request Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants