-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎁 Allow to change the message for the spinner #1973
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cardil: 2 warnings.
In response to this:
Changes
- 🎁 Allow to change the message for the spinner
Reference
Required for knative-extensions/kn-plugin-event#375
/kind enhancement
Release Note
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
14dac66
to
ebde262
Compare
ebde262
to
6b94cc6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1973 +/- ##
==========================================
+ Coverage 73.68% 73.70% +0.01%
==========================================
Files 234 234
Lines 16471 16482 +11
==========================================
+ Hits 12137 12148 +11
Misses 3506 3506
Partials 828 828 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cardil, rhuss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
## release-1.16 Backport of knative#1973 Required for openshift-knative/kn-plugin-event#556
Changes
Reference
Required for knative-extensions/kn-plugin-event#375
/kind enhancement
Release Note