Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎁 Allow to change the message for the spinner #1973

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

cardil
Copy link
Contributor

@cardil cardil commented Oct 25, 2024

Changes

  • 🎁 Allow to change the message for the spinner

Reference

Required for knative-extensions/kn-plugin-event#375

/kind enhancement

Release Note


Copy link

@knative-prow knative-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cardil: 2 warnings.

In response to this:

Changes

  • 🎁 Allow to change the message for the spinner

Reference

Required for knative-extensions/kn-plugin-event#375

/kind enhancement

Release Note


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 25, 2024
@cardil cardil force-pushed the feature/updateable-spinner branch from 14dac66 to ebde262 Compare October 25, 2024 11:24
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.70%. Comparing base (b3b6b86) to head (6b94cc6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1973      +/-   ##
==========================================
+ Coverage   73.68%   73.70%   +0.01%     
==========================================
  Files         234      234              
  Lines       16471    16482      +11     
==========================================
+ Hits        12137    12148      +11     
  Misses       3506     3506              
  Partials      828      828              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2024
Copy link

knative-prow bot commented Oct 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2024
@knative-prow knative-prow bot merged commit 117a365 into knative:main Oct 28, 2024
23 checks passed
@cardil cardil deleted the feature/updateable-spinner branch October 28, 2024 11:53
cardil added a commit to cardil/knative-client that referenced this pull request Nov 5, 2024
openshift-merge-bot bot pushed a commit to openshift-knative/client that referenced this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants