Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address linter warnings in 925 #926

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

dprotaso
Copy link
Contributor

@dprotaso dprotaso commented Jan 10, 2025

Addressed warnings in #925

@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 10, 2025
@knative-prow knative-prow bot requested review from davidhadas and salaboy January 10, 2025 03:12
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2025
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 10, 2025
@dprotaso
Copy link
Contributor Author

/assign @skonto

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 4.23%. Comparing base (26ea83e) to head (b5798ab).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...kg/reconciler/simpledeployment/simpledeployment.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #926   +/-   ##
=====================================
  Coverage   4.23%   4.23%           
=====================================
  Files         16      16           
  Lines        307     307           
=====================================
  Hits          13      13           
  Misses       294     294           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skonto
Copy link

skonto commented Jan 10, 2025

/retest

@skonto
Copy link

skonto commented Jan 10, 2025

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2025
Copy link

knative-prow bot commented Jan 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dprotaso
Copy link
Contributor Author

/override "codecov/patch"

Copy link

knative-prow bot commented Jan 10, 2025

@dprotaso: Overrode contexts on behalf of dprotaso: codecov/patch

In response to this:

/override "codecov/patch"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot merged commit 34485e0 into knative-extensions:main Jan 10, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants