Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎁 Easier debugging, especially for the in-cluster sender #375

Merged
merged 16 commits into from
Oct 29, 2024
Merged

🎁 Easier debugging, especially for the in-cluster sender #375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
354fe78
Easier to debug the failures, especially for in-cluster sender
cardil Oct 18, 2024
387d05d
Configurable retries and deadline for ICS
cardil Oct 22, 2024
22a8946
Collect and log in-cluster job' pods and their logs
cardil Oct 22, 2024
25e50db
Fancy error handler
cardil Oct 22, 2024
c8b0bf4
Merge remote-tracking branch 'upstream/main' into feature/debug-abillity
cardil Oct 22, 2024
6f30714
Linter fixes
cardil Oct 22, 2024
ff89790
Gather K8s events as well
cardil Oct 23, 2024
a11bd93
Using TUI package to bring fancy UI for error handling
cardil Oct 23, 2024
cc81da0
Merge remote-tracking branch 'upstream/main' into feature/debug-abillity
cardil Oct 24, 2024
7e24786
Unit tests fixes
cardil Oct 24, 2024
86f6767
Remove deactivated linters
cardil Oct 24, 2024
52f8f71
Update e2e tests to refer to exec log on failure
cardil Oct 24, 2024
39d0f9f
Fixing the test (but still have race condition)
cardil Oct 24, 2024
0b7e3c6
Remove spinner race condition
cardil Oct 25, 2024
9f237ff
Error handler test
cardil Oct 25, 2024
3d07d88
Update deps
cardil Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .golangci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,8 @@ linters:
disable:
- paralleltest
- nlreturn
- exhaustivestruct
- wsl
- godox
- scopelint
- maligned
- interfacer
- golint
- ireturn
- varnamelen
- exhaustruct
Expand Down
4 changes: 2 additions & 2 deletions build/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,8 +191,8 @@ require (
k8s.io/apimachinery v0.30.3 // indirect
k8s.io/klog/v2 v2.130.1 // indirect
k8s.io/utils v0.0.0-20240711033017-18e509b52bc8 // indirect
knative.dev/client-pkg v0.0.0-20240808015000-22f598931483 // indirect
knative.dev/pkg v0.0.0-20241021183759-9b9d535af5ad // indirect
knative.dev/client-pkg v0.0.0-20241022130700-7b4bb48ac250 // indirect
knative.dev/pkg v0.0.0-20241026180704-25f6002b00f3 // indirect
sigs.k8s.io/json v0.0.0-20221116044647-bc3834ca7abd // indirect
sigs.k8s.io/kind v0.22.0 // indirect
sigs.k8s.io/structured-merge-diff/v4 v4.4.1 // indirect
Expand Down
8 changes: 4 additions & 4 deletions build/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -798,10 +798,10 @@ k8s.io/klog/v2 v2.130.1 h1:n9Xl7H1Xvksem4KFG4PYbdQCQxqc/tTUyrgXaOhHSzk=
k8s.io/klog/v2 v2.130.1/go.mod h1:3Jpz1GvMt720eyJH1ckRHK1EDfpxISzJ7I9OYgaDtPE=
k8s.io/utils v0.0.0-20240711033017-18e509b52bc8 h1:pUdcCO1Lk/tbT5ztQWOBi5HBgbBP1J8+AsQnQCKsi8A=
k8s.io/utils v0.0.0-20240711033017-18e509b52bc8/go.mod h1:OLgZIPagt7ERELqWJFomSt595RzquPNLL48iOWgYOg0=
knative.dev/client-pkg v0.0.0-20240808015000-22f598931483 h1:jBfmxcR0H5Z9IzamelZtmmg9jfeOXfssllUVX5M4Xzs=
knative.dev/client-pkg v0.0.0-20240808015000-22f598931483/go.mod h1:Y56KfZx3gJJpju88l86jQ9csxywLiopR0GkxCWW3+Kg=
knative.dev/pkg v0.0.0-20241021183759-9b9d535af5ad h1:Nrjtr2H168rJeamH4QdyLMV1lEKHejNhaj1ymgQMfLk=
knative.dev/pkg v0.0.0-20241021183759-9b9d535af5ad/go.mod h1:StJI72GWcm/iErmk4RqFJiOo8RLbVqPbHxUqeVwAzeo=
knative.dev/client-pkg v0.0.0-20241022130700-7b4bb48ac250 h1:hxR3hLPdJ9N+qC0ULT2vxTqXyzX8o/0W9ZfUmZ+XBBE=
knative.dev/client-pkg v0.0.0-20241022130700-7b4bb48ac250/go.mod h1:1Wp8+rz7JT3c17r0+2IdxWjkNvEZ/4/AHywaV12nq3I=
knative.dev/pkg v0.0.0-20241026180704-25f6002b00f3 h1:uUSDGlOIkdPT4svjlhi+JEnP2Ufw7AM/F5QDYiEL02U=
knative.dev/pkg v0.0.0-20241026180704-25f6002b00f3/go.mod h1:FeMbTLlxQqSASwlRCrYEOsZ0OKUgSj52qxhECwYCJsw=
knative.dev/toolbox/magetasks v0.0.0-20240412084849-703489d35306 h1:mG2rEGCg4vZAs+D2rIzISuqmND8HNkcNCYvRmEXvG8s=
knative.dev/toolbox/magetasks v0.0.0-20240412084849-703489d35306/go.mod h1:+LHHOXHlXXXiD8WG0ke72XTt/SSpSqUUX1dG8h9AGIE=
rsc.io/binaryregexp v0.2.0/go.mod h1:qTv7/COck+e2FymRvadv62gMdZztPaShugOCi3I+8D8=
Expand Down
2 changes: 1 addition & 1 deletion cmd/kn-event/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@ import (
)

func main() {
commandline.New(new(cli.App)).ExecuteOrDie(cli.Options...)
commandline.New(new(cli.App)).ExecuteOrDie(cli.EffectiveOptions()...)
}
39 changes: 29 additions & 10 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ go 1.22.0

require (
github.com/cloudevents/sdk-go/v2 v2.15.2
github.com/fatih/color v1.16.0
github.com/ghodss/yaml v1.0.0
github.com/gobuffalo/flect v1.0.3
github.com/google/go-containerregistry v0.19.1
Expand All @@ -13,22 +14,23 @@ require (
github.com/pkg/errors v0.9.1
github.com/spf13/cobra v1.8.1
github.com/spf13/pflag v1.0.5
github.com/spf13/viper v1.18.2
github.com/stretchr/testify v1.9.0
github.com/thediveo/enumflag v0.10.0
github.com/wavesoftware/go-commandline v1.1.0
github.com/wavesoftware/go-commandline v1.3.0
github.com/wavesoftware/go-ensure v1.0.0
go.uber.org/zap v1.27.0
gopkg.in/yaml.v2 v2.4.0
gotest.tools/v3 v3.5.1
k8s.io/api v0.30.3
k8s.io/apimachinery v0.30.3
k8s.io/client-go v0.30.3
knative.dev/client/pkg v0.0.0-20241016014431-dbb49e603ce2
knative.dev/eventing v0.42.1-0.20241016013536-6aa49dc1db88
knative.dev/hack v0.0.0-20241010131451-05b2fb30cb4d
knative.dev/pkg v0.0.0-20241021183759-9b9d535af5ad
knative.dev/reconciler-test v0.0.0-20241015093232-09111f0f1364
knative.dev/serving v0.42.1-0.20241021145327-c93d8c49a1b7
knative.dev/client/pkg v0.0.0-20241028111248-117a365d93f7
knative.dev/eventing v0.43.1-0.20241028083747-ef6b31a697e7
knative.dev/hack v0.0.0-20241025103803-ef6e7e983a60
knative.dev/pkg v0.0.0-20241026180704-25f6002b00f3
knative.dev/reconciler-test v0.0.0-20241024141702-aae114c1c0e3
knative.dev/serving v0.43.1-0.20241025124202-16d2da814851
sigs.k8s.io/yaml v1.4.0
)

Expand All @@ -39,15 +41,23 @@ require (
emperror.dev/errors v0.8.1 // indirect
github.com/Azure/go-ansiterm v0.0.0-20230124172434-306776ec8161 // indirect
github.com/antlr/antlr4/runtime/Go/antlr v1.4.10 // indirect
github.com/atotto/clipboard v0.1.4 // indirect
github.com/aymanbagabas/go-osc52/v2 v2.0.1 // indirect
github.com/beorn7/perks v1.0.1 // indirect
github.com/blendle/zapdriver v1.3.1 // indirect
github.com/census-instrumentation/opencensus-proto v0.4.1 // indirect
github.com/cespare/xxhash/v2 v2.3.0 // indirect
github.com/charmbracelet/bubbles v0.18.0 // indirect
github.com/charmbracelet/bubbletea v0.25.0 // indirect
github.com/charmbracelet/harmonica v0.2.0 // indirect
github.com/charmbracelet/lipgloss v0.10.0 // indirect
github.com/cloudevents/conformance v0.2.0 // indirect
github.com/cloudevents/sdk-go/sql/v2 v2.15.2 // indirect
github.com/containerd/console v1.0.4 // indirect
github.com/creack/pty v1.1.21 // indirect
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect
github.com/emicklei/go-restful/v3 v3.12.1 // indirect
github.com/erikgeiser/promptkit v0.9.0 // indirect
github.com/evanphx/json-patch v5.9.0+incompatible // indirect
github.com/evanphx/json-patch/v5 v5.9.0 // indirect
github.com/fsnotify/fsnotify v1.7.0 // indirect
Expand Down Expand Up @@ -75,14 +85,23 @@ require (
github.com/josharian/intern v1.0.0 // indirect
github.com/json-iterator/go v1.1.12 // indirect
github.com/liggitt/tabwriter v0.0.0-20181228230101-89fcab3d43de // indirect
github.com/lucasb-eyer/go-colorful v1.2.0 // indirect
github.com/magiconair/properties v1.8.7 // indirect
github.com/mailru/easyjson v0.7.7 // indirect
github.com/mattn/go-colorable v0.1.13 // indirect
github.com/mattn/go-isatty v0.0.20 // indirect
github.com/mattn/go-localereader v0.0.2-0.20220822084749-2491eb6c1c75 // indirect
github.com/mattn/go-runewidth v0.0.15 // indirect
github.com/mitchellh/go-homedir v1.1.0 // indirect
github.com/mitchellh/mapstructure v1.5.0 // indirect
github.com/moby/term v0.5.0 // indirect
github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
github.com/modern-go/reflect2 v1.0.2 // indirect
github.com/monochromegane/go-gitignore v0.0.0-20200626010858-205db1a8cc00 // indirect
github.com/muesli/ansi v0.0.0-20230316100256-276c6243b2f6 // indirect
github.com/muesli/cancelreader v0.2.2 // indirect
github.com/muesli/reflow v0.3.0 // indirect
github.com/muesli/termenv v0.15.2 // indirect
github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect
github.com/nxadm/tail v1.4.11 // indirect
github.com/onsi/ginkgo v1.16.5 // indirect
Expand All @@ -98,13 +117,13 @@ require (
github.com/prometheus/statsd_exporter v0.22.8 // indirect
github.com/rickb777/date v1.20.0 // indirect
github.com/rickb777/plural v1.4.1 // indirect
github.com/rivo/uniseg v0.4.7 // indirect
github.com/robfig/cron/v3 v3.0.1 // indirect
github.com/sagikazarmark/locafero v0.4.0 // indirect
github.com/sagikazarmark/slog-shim v0.1.0 // indirect
github.com/sourcegraph/conc v0.3.0 // indirect
github.com/spf13/afero v1.11.0 // indirect
github.com/spf13/cast v1.6.0 // indirect
github.com/spf13/viper v1.18.2 // indirect
github.com/subosito/gotenv v1.6.0 // indirect
github.com/wavesoftware/go-retcode v1.0.0 // indirect
github.com/xlab/treeprint v1.2.0 // indirect
Expand Down Expand Up @@ -134,8 +153,8 @@ require (
k8s.io/klog/v2 v2.130.1 // indirect
k8s.io/kube-openapi v0.0.0-20240808142205-8e686545bdb8 // indirect
k8s.io/utils v0.0.0-20240711033017-18e509b52bc8 // indirect
knative.dev/client-pkg v0.0.0-20240808015000-22f598931483 // indirect
knative.dev/networking v0.0.0-20241015085032-a3d46633cfb3 // indirect
knative.dev/client-pkg v0.0.0-20241022130700-7b4bb48ac250 // indirect
knative.dev/networking v0.0.0-20241024135302-d5387fab1de1 // indirect
sigs.k8s.io/json v0.0.0-20221116044647-bc3834ca7abd // indirect
sigs.k8s.io/kustomize/api v0.13.5-0.20230601165947-6ce0bf390ce3 // indirect
sigs.k8s.io/kustomize/kyaml v0.14.3-0.20230601165947-6ce0bf390ce3 // indirect
Expand Down
Loading
Loading