Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the wheel build #157

Merged
merged 5 commits into from
Sep 25, 2024
Merged

Fix the wheel build #157

merged 5 commits into from
Sep 25, 2024

Conversation

kiyo-masui
Copy link
Owner

No description provided.

@kiyo-masui
Copy link
Owner Author

@ketiltrout Just trying to fix the release system. I solved a few problems, but the wheel build still fails when it's tested... looks like the tests can't import the modules.

See: https://github.com/kiyo-masui/bitshuffle/actions/runs/11016468354

@DimitriPapadopoulos
Copy link
Contributor

See also #142.

@ljgray
Copy link
Collaborator

ljgray commented Sep 24, 2024

@kiyo-masui @ketiltrout

Ok, this should be fixed. See https://github.com/kiyo-masui/bitshuffle/actions/runs/11022245770.

The underlying issue with the build is that it was trying to install hdf5 version 1.14.4, but there actually aren't any distributions available - we have to include the patch number, the most recent of which is -3. As a result, hdf5 wasn't getting installed and bitshuffle was failing when trying to import it. In order to fix this, I:

  • specified hdf5 version 1.14.4-3 in the workflow
  • modified install_hdf5.sh to handle a patch version

I also had to add a minimum python_requires to setup.py. cibuildwheel uses this to decide which version to build on, and in the absence of any specification it seemed to be falling back to python 3.6.

Finally, I updated the build requirements to support numpy 2.0. According to numpy 2.0 dependency docs, wheels built against numpy 2.x will be compatible with numpy 1.xx. numpy 2.0.0rc1 is the first numpy 2 release candidate, so building against that (at minimum) should still support numpy 1.xx. I also updated the minimum supported numpy to 1.24, based on the numpy drop schedule.

@kiyo-masui
Copy link
Owner Author

Wow - thank you! I struggled with this for a few hours but no way I would have figured this out!

@kiyo-masui kiyo-masui merged commit a3e7314 into master Sep 25, 2024
9 checks passed
@ljgray ljgray deleted the fixwheels branch September 25, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants