-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the wheel build #157
Fix the wheel build #157
Conversation
@ketiltrout Just trying to fix the release system. I solved a few problems, but the wheel build still fails when it's tested... looks like the tests can't import the modules. See: https://github.com/kiyo-masui/bitshuffle/actions/runs/11016468354 |
See also #142. |
…ibility Numpy 1.24 is the current oldest supported numpy version. Building against numpy 2.0.0rc1 will support numpy >= 1.21
Ok, this should be fixed. See https://github.com/kiyo-masui/bitshuffle/actions/runs/11022245770. The underlying issue with the build is that it was trying to install hdf5 version 1.14.4, but there actually aren't any distributions available - we have to include the patch number, the most recent of which is
I also had to add a minimum Finally, I updated the build requirements to support numpy 2.0. According to numpy 2.0 dependency docs, wheels built against numpy 2.x will be compatible with numpy 1.xx. numpy 2.0.0rc1 is the first numpy 2 release candidate, so building against that (at minimum) should still support numpy 1.xx. I also updated the minimum supported numpy to 1.24, based on the numpy drop schedule. |
Wow - thank you! I struggled with this for a few hours but no way I would have figured this out! |
No description provided.