You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Following discussion in kiwix/kiwix-build#346 it became clear that this would be an added value to be able to fully validate (so Android version of the libkiwix too) automatically and within kwix-lib repo.
The text was updated successfully, but these errors were encountered:
I'm supportive of this, but I would really appreciate that we can do that without building a complex infrastructure. Considering that the JNI binding is a really thin layer, it would be IMO to "expensive" to have to setup a full Google Android development setup to test this.
I'm interested to get first a description of the technical approach before any implementation effort.
This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.
@mgautierfr@MohitMaliFtechiz I guess this has been done meanwhile or do we still have old test cases of the libkiwix binding which are still not activated here in this repo?
The discussion in kiwix/kiwix-build#346 is pretty old so I don't remember exactly what we expect from aar automated testing. But:
java-libkiwix now has test of the wrapper. Those tests are run in the CI and can be run locally.
java-libkiwix gradle is creating a aar locally and can upload (through the CI) to maven.
So I suspect we are ok and we can close this issue.
If something is missing, the best will be to open a specific issue with a more specific description of the problem and what to do.
Following discussion in kiwix/kiwix-build#346 it became clear that this would be an added value to be able to fully validate (so Android version of the libkiwix too) automatically and within kwix-lib repo.
The text was updated successfully, but these errors were encountered: