Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Kiwix Android .aar automated testing to libkiwix automated framework #3

Closed
kelson42 opened this issue Aug 12, 2019 · 4 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@kelson42
Copy link
Contributor

Following discussion in kiwix/kiwix-build#346 it became clear that this would be an added value to be able to fully validate (so Android version of the libkiwix too) automatically and within kwix-lib repo.

@kelson42
Copy link
Contributor Author

I'm supportive of this, but I would really appreciate that we can do that without building a complex infrastructure. Considering that the JNI binding is a really thin layer, it would be IMO to "expensive" to have to setup a full Google Android development setup to test this.

I'm interested to get first a description of the technical approach before any implementation effort.

@stale
Copy link

stale bot commented Nov 21, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@kelson42 kelson42 transferred this issue from kiwix/libkiwix May 13, 2021
@kelson42 kelson42 added the enhancement New feature or request label May 13, 2021
@kelson42 kelson42 added this to the 1.0.0 milestone Jul 18, 2023
@kelson42
Copy link
Contributor Author

@mgautierfr @MohitMaliFtechiz I guess this has been done meanwhile or do we still have old test cases of the libkiwix binding which are still not activated here in this repo?

@mgautierfr
Copy link
Member

The discussion in kiwix/kiwix-build#346 is pretty old so I don't remember exactly what we expect from aar automated testing. But:

  • java-libkiwix now has test of the wrapper. Those tests are run in the CI and can be run locally.
  • java-libkiwix gradle is creating a aar locally and can upload (through the CI) to maven.

So I suspect we are ok and we can close this issue.
If something is missing, the best will be to open a specific issue with a more specific description of the problem and what to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants