-
Notifications
You must be signed in to change notification settings - Fork 10
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Constrain logo proportions to 200x80 (#461)
- Loading branch information
Showing
2 changed files
with
12 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Constrain logo proportions to 200x80. @sneridagh |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21bb97d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am curious why this hard limitation change to autoscale into this box is named "Constrain proportion" and why it ended so small?
Should be "limit logo bounding box to" instead to reflect the purpose/effect better. Constrain proportion means "fixed aspect ratio" to something like the golden ratio 1,618 or 16:9. As long as this is not in the UI and just the commit message, it is not that big problem.
I am here because the change spoiled my recent attempts to work around ;-) and it took me here.
From a designers perspective the aspect ratio of word/image devices can vary a lot and have a visual weigth and balance and safe areas.
The fine adjustment is often be done by placing a transparent element in a safe area frame, but these settings should also be accessible easily as CSS padding. Since the same logo is also present by default in the footer as well, understanding the layout possibilities of this in VLT needs a bit more love by me.
Is there a related option in the upcoming TTW reachable settings?