Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Correct swapped width and height attributes in SVG tag #3

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

seongbae15
Copy link
Contributor

I am very interested in your research. While executing your code line by line, I noticed that during the keypoint detection process, the width and height of a non-square SVG file were swapped. Please take a look and review it.

This PR fixes an issue where the width and height attributes in the SVG tag were mistakenly swapped. Previously, width was assigned to self.viewbox.wh.y, and height was assigned to self.viewbox.wh.x. This was incorrect, as width should correspond to the X-dimension and height to the Y-dimension.

To correct this, the values have been properly reassigned:

width → self.viewbox.wh.x
height → self.viewbox.wh.y

@kingnobro kingnobro merged commit 77bb0fa into kingnobro:main Feb 11, 2025
@kingnobro
Copy link
Owner

I always use square SVG, so this error was not found by me. Thank you for your careful check!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants