Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable tls on elasticsearch connect #42

Merged
merged 1 commit into from
Aug 25, 2024
Merged

fix: disable tls on elasticsearch connect #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions brownie/src/modules/elasticsearch/implementation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ export const clean = async (moduleName: string, config: Config, moduleConfig: El
const client = new Client({
auth: basicAuth,
nodes: nodes as string[],
tls: {
rejectUnauthorized: false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yian-shih do you think having this as parameter is a good idea?

Copy link
Collaborator Author

@yian-shih yian-shih Aug 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Marek,
Yes, we can do that.
In the future, if any apps that need different configs then we can use parameter.
In that case, we would have better idea which config we need to enable as dynamic variables.
As all of our apps use the same config for Elasticsearch so I just keep this connection with minimum config

},
})

logger.info("%s.clean(): Connecting to Elasticsearch server...", moduleName)
Expand Down
Loading