Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gh-85): take git tokens from env variables at first #88

Merged
merged 1 commit into from
Dec 10, 2023

Conversation

lampajr
Copy link
Member

@lampajr lampajr commented Dec 6, 2023

Thank you for submitting this pull request

fixes #85

Checklist

  • Tests added if applicable.
  • Documentation updated if applicable.

Note: dist/cli/index.js and dist/gha/index.js are automatically generated by git hooks and gh workflows.

First time here?

This project follows git conventional commits pattern, therefore the commits should have the following format:

<type>(<optional scope>): <subject>
empty separator line
<optional body>
empty separator line
<optional footer>

Where the type must be one of [build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test]

NOTE: if you are still in a work in progress branch and you want to push your changes remotely, consider adding --no-verify for both commit and push, e.g., git push origin <feat-branch> --no-verify - this could become useful to push changes where there are still tests failures. Once the pull request is ready, please amend the commit and force-push it to keep following the adopted git commit standard.

How to prepare for a new release?

There is no need to manually update package.json version and CHANGELOG.md information. This process has been automated in Prepare Release Github workflow.

Therefore whenever enough changes are merged into the main branch, one of the maintainers will trigger this workflow that will automatically update version and changelog based on the commits on the git tree.

More details can be found in package release section of the README.

Copy link
Contributor

github-actions bot commented Dec 6, 2023

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
90.26% (+0.21% 🔼)
417/462
🟢 Branches
82.83% (-0.23% 🔻)
164/198
🟢 Functions
88.98% (+0.49% 🔼)
105/118
🟢 Lines
90.22% (+0.22% 🔼)
406/450
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / configs.types.ts
100% 100% 100% 100%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / configs-parser.ts
91.67% (-8.33% 🔻)
83.33% (-16.67% 🔻)
100%
91.67% (-8.33% 🔻)
🟢
... / github-client.ts
87.5% (+0.54% 🔼)
76.92% (-3.08% 🔻)
71.43% (+2.2% 🔼)
87.23% (+0.57% 🔼)

Test suite run success

165 tests passing in 16 suites.

Report generated by 🧪jest coverage report action from 9d712aa

@lampajr lampajr merged commit 70da575 into kiegroup:main Dec 10, 2023
4 checks passed
@lampajr lampajr deleted the gh85_token_as_env branch December 10, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow passing secrets as environment variable
1 participant