fix: cherry-pick multiple commits in the correct order

[earl-warren]

Fixes: #114

[github-actions]

Coverage report

St.❔	Category	Percentage	Covered / Total
🟢	Statements	90.84%	446/491
🟢	Branches	85.85%	176/205
🟢	Functions	88.33%	106/120
🟢	Lines	90.78%	433/477

Test suite run success

175 tests passing in 16 suites.

Report generated by 🧪jest coverage report action from e06c3a9

[lampajr]

there's something I'm not sure about, in that with this fix (for github at least) the reverse is applied twice:

1. when mapping the original pr https://github.com/kiegroup/git-backporting/pull/115/files#diff-6e3804f9a1581e5155295a17bbbc71343fa375a15bf5383dd4c4049a44be09cdR64
2. when it has to scroll and cherry-pick the commits https://github.com/kiegroup/git-backporting/pull/115/files#diff-80854020f781d333495ba48208afccf09b44b58790aae94b10731f47b78e86ebR149

This means that at the end you are applying the commits in the same order as it was before 🤔

I need to check this a bit more

[lampajr]

Ok I think we have two options here:

1. Change the commits order during the original pull request fetch (i.e., during the mapping) and then change all the tests as you already did
2. Change the order in which the commits are applied (i.e., in the runner) and then no other changes would be required

NOTE: option 1 would require a change in the gitlab client as well

[earl-warren]

there's something I'm not sure about, in that with this fix (for github at least) the reverse is applied twice:

1. when mapping the original pr https://github.com/kiegroup/git-backporting/pull/115/files#diff-6e3804f9a1581e5155295a17bbbc71343fa375a15bf5383dd4c4049a44be09cdR64

2. when it has to scroll and cherry-pick the commits https://github.com/kiegroup/git-backporting/pull/115/files#diff-80854020f781d333495ba48208afccf09b44b58790aae94b10731f47b78e86ebR149

This means that at the end you are applying the commits in the same order as it was before 🤔

I need to check this a bit more

That's a leftover of a earlier attempt, my bad. And good catch.

[earl-warren]

Change the order in which the commits are applied (i.e., in the runner) and then no other changes would be required

That sounds better. I'll go with that now that I better understand where's what.

[lampajr]

Change the order in which the commits are applied (i.e., in the runner) and then no other changes would be required

That sounds better. I'll go with that now that I better understand where's what.

yeah I agree with you.

It could be useful to add something like this expect(GitCLIService.prototype.cherryPick).toHaveBeenLastCalledWith(cwd, "0404fb922ab75c3a8aecad5c97d9af388df04695", undefined, undefined) here

git-backporting/test/service/runner/cli-github-runner.test.ts

Lines 683 to 685 in fe6be83

	expect(GitCLIService.prototype.cherryPick).toBeCalledTimes(2);
	expect(GitCLIService.prototype.cherryPick).toBeCalledWith(cwd, "0404fb922ab75c3a8aecad5c97d9af388df04695", undefined, undefined, undefined);
	expect(GitCLIService.prototype.cherryPick).toBeCalledWith(cwd, "11da4e38aa3e577ffde6d546f1c52e53b04d3151", undefined, undefined, undefined);

This way you can assure what is the last call of that method

[earl-warren]

Change the order in which the commits are applied (i.e., in the runner) and then no other changes would be required

That sounds better. I'll go with that now that I better understand where's what.

yeah I agree with you.

It could be useful to add something like this expect(GitCLIService.prototype.cherryPick).toHaveBeenLastCalledWith(cwd, "0404fb922ab75c3a8aecad5c97d9af388df04695", undefined, undefined) here

git-backporting/test/service/runner/cli-github-runner.test.ts

Lines 683 to 685 in fe6be83

	expect(GitCLIService.prototype.cherryPick).toBeCalledTimes(2);
	expect(GitCLIService.prototype.cherryPick).toBeCalledWith(cwd, "0404fb922ab75c3a8aecad5c97d9af388df04695", undefined, undefined, undefined);
	expect(GitCLIService.prototype.cherryPick).toBeCalledWith(cwd, "11da4e38aa3e577ffde6d546f1c52e53b04d3151", undefined, undefined, undefined);

This way you can assure what is the last call of that method

Thanks for the hint, exactly what I was looking for ❤️

[earl-warren]

Should be better now.

[lampajr]

Should be better now.

Indeed, sounds great! Merging this ❤️