Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: send native currency and asas to another account #37

Merged
merged 17 commits into from
Dec 5, 2023
Merged

feat: send native currency and asas to another account #37

merged 17 commits into from
Dec 5, 2023

Conversation

kieranroneill
Copy link
Member

@kieranroneill kieranroneill commented Dec 5, 2023 •
edited
Loading

Description

  • Update manifest version update script to omit pre-release suffixes
  • Add react-select package
  • Fetch transaction params for a network and save to storage
  • Poll fetching transaction params
  • Add button to send native currency from the side bar
  • Open send assets modal when pressing the send button from the assets page
  • Allow sending of native currencies and ASAs
  • Overhauled how account information and transactions are fetched
  • Fetch updated account information and refresh transactions on send asset completion
  • Handle send asset errors with a toast message
  • Display toast when successful send of asset
  • Account page tabs should persist through account change
  • Accounts in the sidebar without a name should align left

Type of change

  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🏗️ Build configuration (CI configuration, scaffolding etc.)
  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 📝 Documentation update(s)
  • 📦 Dependency update(s)
  • 👩🏽‍💻 Improve developer experience
  • ⚡ Improve performance
  • ✨ New feature (non-breaking change which adds functionality)
  • ♻ Refactor
  • ⏪ Revert changes
  • 🧪 New tests or updates to existing tests

@kieranroneill
feat: add button to open send asset modal
834a4b9
@kieranroneill
feat: add network transaction params to storage
4e7ce3d
@kieranroneill
feat: add send input to calculate maximum transaction aount
28dae32
@kieranroneill
feat: add asset select
84c86ae
@kieranroneill
feat: add share address modal when clicking the receive button
11b02ad
@kieranroneill
feat: add to address and note fields
37743bc
@kieranroneill
feat: add summary page
9783262
@kieranroneill
feat: add thunk to send transaction
d83d06f
@kieranroneill
feat: add toast when error or completion of trnasaction submission
8de7e6f
@kieranroneill
feat: update account information when confirmation of asset transafer
f0c11ab
@kieranroneill
fix: account tab selection persists through account selection
f6a1f8e
@kieranroneill
fix: sidebar account address aligns left
9cccfca
@kieranroneill
feat: use toast from hook and handle errors in send asset modal
3210b82
@kieranroneill
refactor: account information and account transaction thunk use lists…
e34aa4c 
… of account ids
@kieranroneill
feat: add transaction to send asset toast messages
8dc800e
@kieranroneill
feat: shrink inputs to medium size
f026702
@kieranroneill kieranroneill added ♻️ refactor The refactoring fairy has waved their magic wand ✨ feature New feature or request 🐛 bug Something isn't working labels Dec 5, 2023
@kieranroneill kieranroneill self-assigned this Dec 5, 2023
@kieranroneill kieranroneill added the 🏗️ build Updates to the build and CI systems label Dec 5, 2023
@kieranroneill kieranroneill merged commit 525727c into beta Dec 5, 2023
7 checks passed
@kieranroneill kieranroneill deleted the feat/send-asset-to-another-account branch December 5, 2023 13:32
github-actions bot pushed a commit that referenced this pull request Dec 5, 2023
@agoralabs-bot
chore(release): 1.6.0-beta.2
99c8959 
# [1.6.0-beta.2](v1.6.0-beta.1...v1.6.0-beta.2) (2023-12-05)

### Features

* send native currency and asas to another account ([#37](#37)) ([525727c](525727c))
@agoralabs-bot
Copy link
Contributor

🎉 This PR is included in version 1.6.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@agoralabs-bot agoralabs-bot added the 🚀 released To the moon! label Dec 5, 2023
github-actions bot pushed a commit that referenced this pull request Dec 6, 2023
@agoralabs-bot
chore(release): 1.6.0
f73e910 
# [1.6.0](v1.5.2...v1.6.0) (2023-12-06)

### Bug Fixes

* registration window not closing on chrome ([#39](#39)) ([0834389](0834389))

### Features

* add voi testnet block explorer ([#38](#38)) ([b7498d1](b7498d1))
* send native currency and asas to another account ([#37](#37)) ([525727c](525727c))
* use testnet by default and add settings option to allow mainnet ([#36](#36)) ([593785b](593785b))
@agoralabs-bot
Copy link
Contributor

🎉 This PR is included in version 1.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kieranroneill kieranroneill

Labels
🐛 bug Something isn't working 🏗️ build Updates to the build and CI systems ✨ feature New feature or request ♻️ refactor The refactoring fairy has waved their magic wand 🚀 released To the moon!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kieranroneill @agoralabs-bot