Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignore non-utf-8 encoded notes #341

Merged
merged 2 commits into from
Oct 18, 2024
Merged

fix: ignore non-utf-8 encoded notes #341

merged 2 commits into from
Oct 18, 2024

Conversation

kieranroneill
Copy link
Member

Description

  • dApp example deploy workflow now uses GitHub's official actions.
  • Parsing transaction note attempts to decoded to UTF-8, if it fails it gracefully errors.

Type of change

  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🏗️ Build configuration (CI configuration, scaffolding etc.)
  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 📝 Documentation update(s)
  • 📦 Dependency update(s)
  • 👩🏽‍💻 Improve developer experience
  • ⚡ Improve performance
  • ✨ New feature (non-breaking change which adds functionality)
  • ♻ Refactor
  • ⏪ Revert changes
  • 🧪 New tests or updates to existing tests

@kieranroneill kieranroneill added 🏗️ build Updates to the build and CI systems 🐛 bug Something isn't working labels Oct 18, 2024
@kieranroneill kieranroneill self-assigned this Oct 18, 2024
@kieranroneill kieranroneill merged commit a24d369 into main Oct 18, 2024
7 checks passed
@kieranroneill kieranroneill deleted the 340-transactions-not-loading branch October 18, 2024 16:14
github-actions bot pushed a commit that referenced this pull request Oct 18, 2024
@kibi-bot
chore(release): 2.3.2
cb5af47 
## [2.3.2](v2.3.1...v2.3.2) (2024-10-18)

### Bug Fixes

* ignore non-utf-8 encoded notes ([#341](#341)) ([a24d369](a24d369))
@kibi-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 2.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kibi-bot kibi-bot added the 🚀 released To the moon! label Oct 18, 2024
@kieranroneill kieranroneill linked an issue Oct 18, 2024 that may be closed by this pull request
Transactions not loading #340
Closed
github-actions bot pushed a commit that referenced this pull request Oct 18, 2024
@kibi-bot
chore(release): 2.4.0-beta.3
12a6304 
# [2.4.0-beta.3](v2.4.0-beta.2...v2.4.0-beta.3) (2024-10-18)

### Bug Fixes

* ignore non-utf-8 encoded notes ([#341](#341)) ([a24d369](a24d369))
@kibi-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 2.4.0-beta.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kieranroneill kieranroneill

Labels
🐛 bug Something isn't working 🏗️ build Updates to the build and CI systems 🚀 released To the moon!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transactions not loading
2 participants
@kieranroneill @kibi-bot