Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use fixed integers in atomic unit bignumber conversions #337

Merged
merged 4 commits into from
Oct 3, 2024
Merged

fix: use fixed integers in atomic unit bignumber conversions #337

merged 4 commits into from
Oct 3, 2024

Conversation

kieranroneill
Copy link
Member

Description

  • For atomic unit conversions, use BigNumber.toFixed() to ensure the exponent form is not used such as when using BigNumber.toString().

Type of change

  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🏗️ Build configuration (CI configuration, scaffolding etc.)
  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 📝 Documentation update(s)
  • 📦 Dependency update(s)
  • 👩🏽‍💻 Improve developer experience
  • ⚡ Improve performance
  • ✨ New feature (non-breaking change which adds functionality)
  • ♻ Refactor
  • ⏪ Revert changes
  • 🧪 New tests or updates to existing tests

@kieranroneill kieranroneill added the 🐛 bug Something isn't working label Oct 3, 2024
@kieranroneill kieranroneill self-assigned this Oct 3, 2024
@kieranroneill kieranroneill merged commit ee33fab into main Oct 3, 2024
9 checks passed
@kieranroneill kieranroneill deleted the 336-assets-with-a-lot-of-decimals-failing-to-be-sent-to-the-network branch October 3, 2024 14:09
github-actions bot pushed a commit that referenced this pull request Oct 3, 2024
@agoralabs-bot
chore(release): 2.3.1
d9306f1 
## [2.3.1](v2.3.0...v2.3.1) (2024-10-03)

### Bug Fixes

* use fixed integers in atomic unit bignumber conversions  ([#337](#337)) ([ee33fab](ee33fab))
@kieranroneill kieranroneill linked an issue Oct 3, 2024 that may be closed by this pull request
Assets with a lot of decimals failing to be sent to the network #336
Closed
@agoralabs-bot
Copy link
Contributor

🎉 This issue has been resolved in version 2.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@agoralabs-bot agoralabs-bot added the 🚀 released To the moon! label Oct 3, 2024
github-actions bot pushed a commit that referenced this pull request Oct 3, 2024
@agoralabs-bot
chore(release): 2.4.0-beta.2
8b05121 
# [2.4.0-beta.2](v2.4.0-beta.1...v2.4.0-beta.2) (2024-10-03)

### Bug Fixes

* use fixed integers in atomic unit bignumber conversions  ([#337](#337)) ([ee33fab](ee33fab))
@agoralabs-bot
Copy link
Contributor

🎉 This issue has been resolved in version 2.4.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kieranroneill kieranroneill

Labels
🐛 bug Something isn't working 🚀 released To the moon!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assets with a lot of decimals failing to be sent to the network
2 participants
@kieranroneill @agoralabs-bot