Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow for empty metadata #281

Merged

Conversation

kieranroneill
Copy link
Member

Description

  • NFT metadata is parsed only if it is not empty

Type of change

  • πŸ’₯ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • πŸ—οΈ Build configuration (CI configuration, scaffolding etc.)
  • πŸ› Bug fix (non-breaking change which fixes an issue)
  • πŸ“ Documentation update(s)
  • πŸ“¦ Dependency update(s)
  • πŸ‘©πŸ½β€πŸ’» Improve developer experience
  • ⚑ Improve performance
  • ✨ New feature (non-breaking change which adds functionality)
  • β™» Refactor
  • βͺ Revert changes
  • πŸ§ͺ New tests or updates to existing tests

@kieranroneill kieranroneill added the πŸ› bug Something isn't working label Aug 23, 2024
@kieranroneill kieranroneill self-assigned this Aug 23, 2024
@kieranroneill kieranroneill linked an issue Aug 23, 2024 that may be closed by this pull request
@kieranroneill kieranroneill merged commit bd5bc7a into beta Aug 23, 2024
9 checks passed
@kieranroneill kieranroneill deleted the 276-account-details-not-loading-when-nft-metadata-is-empty branch August 23, 2024 20:54
github-actions bot pushed a commit that referenced this pull request Aug 23, 2024
# [1.18.0-beta.8](v1.18.0-beta.7...v1.18.0-beta.8) (2024-08-23)

### Bug Fixes

* allow for empty metadata ([#281](#281)) ([bd5bc7a](bd5bc7a))
@agoralabs-bot
Copy link
Contributor

πŸŽ‰ This PR is included in version 1.18.0-beta.8 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

@agoralabs-bot agoralabs-bot added the πŸš€ released To the moon! label Aug 23, 2024
github-actions bot pushed a commit that referenced this pull request Aug 27, 2024
# [1.18.0](v1.17.2...v1.18.0) (2024-08-27)

### Bug Fixes

* allow for empty metadata ([#281](#281)) ([bd5bc7a](bd5bc7a))

### Features

* add a 1kb limit to notes ([#283](#283)) ([73600b9](73600b9))
* add a 32 byte limit on account names ([#268](#268)) ([576cc09](576cc09))
* add custom node details ([#278](#278)) ([f393ae6](f393ae6))
* add numbers to the seed phrases and update style ([#280](#280)) ([670f287](670f287))
* allow arrays of private keys and account names when exporting/importing an account via a qr code ([#270](#270)) ([656b95f](656b95f))
* credential lock persists when closing ([#275](#275)) ([7b050ed](7b050ed))
* implement webauthn to encrypt the private keys ([#266](#266)) ([e3dde7f](e3dde7f))
* limit navigator request to one with an array of accounts ([#271](#271)) ([9d51da1](9d51da1))
* pre release UI updates ([#290](#290)) ([65ca387](65ca387))
@agoralabs-bot
Copy link
Contributor

πŸŽ‰ This issue has been resolved in version 1.18.0 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸ› bug Something isn't working πŸš€ released To the moon!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Account details not loading when NFT metadata is empty
2 participants