Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sign button no longer relies for account update #265

Merged
merged 1 commit into from
Jul 10, 2024
Merged

fix: sign button no longer relies for account update #265

merged 1 commit into from
Jul 10, 2024

Conversation

kieranroneill
Copy link
Member

Description

  • Add loading to sign button on the transaction button
  • Get authorized accounts when pressing signing button to fix issue with authorized accounts not being updated until accounts are updated

Type of change

  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🏗️ Build configuration (CI configuration, scaffolding etc.)
  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 📝 Documentation update(s)
  • 📦 Dependency update(s)
  • 👩🏽‍💻 Improve developer experience
  • ⚡ Improve performance
  • ✨ New feature (non-breaking change which adds functionality)
  • ♻ Refactor
  • ⏪ Revert changes
  • 🧪 New tests or updates to existing tests

@kieranroneill kieranroneill added the 🐛 bug Something isn't working label Jul 10, 2024
@kieranroneill kieranroneill self-assigned this Jul 10, 2024
@kieranroneill kieranroneill force-pushed the 263-long-delay-when-signing-transactions branch from 81521b6 to 06eb8d9 Compare July 10, 2024 21:47
@kieranroneill kieranroneill changed the title fix: sign button no longer relies for accouunt update fix: sign button no longer relies for account update Jul 10, 2024
@kieranroneill kieranroneill merged commit bbcba58 into main Jul 10, 2024
9 checks passed
@kieranroneill kieranroneill deleted the 263-long-delay-when-signing-transactions branch July 10, 2024 21:52
@kieranroneill kieranroneill linked an issue Jul 10, 2024 that may be closed by this pull request
Long delay when signing transactions #263
Closed
github-actions bot pushed a commit that referenced this pull request Jul 10, 2024
@agoralabs-bot
chore(release): 1.17.2
ca7fa64 
## [1.17.2](v1.17.1...v1.17.2) (2024-07-10)

### Bug Fixes

* sign button no longer relies for account update ([#265](#265)) ([bbcba58](bbcba58))
@agoralabs-bot
Copy link
Contributor

🎉 This PR is included in version 1.17.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@agoralabs-bot agoralabs-bot added the 🚀 released To the moon! label Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kieranroneill kieranroneill

Labels
🐛 bug Something isn't working 🚀 released To the moon!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Long delay when signing transactions
2 participants
@kieranroneill @agoralabs-bot