Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple groups of transactions as per ARC-0001 #165

Closed
kieranroneill opened this issue Feb 11, 2024 · 0 comments · Fixed by #172
Closed

Allow multiple groups of transactions as per ARC-0001 #165

kieranroneill opened this issue Feb 11, 2024 · 0 comments · Fixed by #172
Assignees
Labels
🐛 bug Something isn't working
Milestone

Comments

@kieranroneill
Copy link
Member

Summary

When signing multiple transactions, an oversight was made in the understanding of the ARC-0001 spec, namely, there can be multiple groups of transactions.

See ARC-0001#Group Validation.

Steps to produce

  • Create multiple groups of transactions
  • Send to Kibisis to be signed

Expected Results

  • The User is presented with the groups of transactions

Actual Results

  • Add error, such as the below, is returned:
"the computed group id "qbbpomwq7jkf6tef2iqeooz/rz7u5gb+icwx/a7qrrg=" does not match the assigned transaction group ids ["ro3sofdzqilctl8wrb5vwexbvtfv42ozg1rqkfpyeuk=","ro3sofdzqilctl8wrb5vwexbvtfv42ozg1rqkfpyeuk=","ro3sofdzqilctl8wrb5vwexbvtfv42ozg1rqkfpyeuk=","ro3sofdzqilctl8wrb5vwexbvtfv42ozg1rqkfpyeuk=","ro3sofdzqilctl8wrb5vwexbvtfv42ozg1rqkfpyeuk=","vdf2ri4v64me1g7f1ljw6tvamsavixenqjucdtmwhaa=","vdf2ri4v64me1g7f1ljw6tvamsavixenqjucdtmwhaa=","vdf2ri4v64me1g7f1ljw6tvamsavixenqjucdtmwhaa="]"
@kieranroneill kieranroneill self-assigned this Feb 11, 2024
@kieranroneill kieranroneill converted this from a draft issue Feb 11, 2024
@kieranroneill kieranroneill added the 🐛 bug Something isn't working label Feb 11, 2024
@kieranroneill kieranroneill added this to the v1.12.0 milestone Feb 11, 2024
@kieranroneill kieranroneill moved this from 📋 Backlog to 🔖 Ready in Kibisis Web Extension Feb 11, 2024
@kieranroneill kieranroneill modified the milestones: v1.12.0, v1.11.1 Feb 12, 2024
@kieranroneill kieranroneill moved this from 🔖 Ready to 🏗 In progress in Kibisis Web Extension Feb 14, 2024
@kieranroneill kieranroneill linked a pull request Feb 16, 2024 that will close this issue
11 tasks
@kieranroneill kieranroneill moved this from 🏗 In progress to ✅ Done in Kibisis Web Extension Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
1 participant