Skip to content

Commit

Permalink
SKA: Fix kebab-case issues in search-kibana packages (elastic#211348)
Browse files Browse the repository at this point in the history
## Summary

This PR aims at relocating some of the Kibana modules (plugins and
packages) into a new folder structure, according to the _Sustainable
Kibana Architecture_ initiative.

> [!IMPORTANT]
> * We kindly ask you to:
> * Manually fix the errors in the error section below (if there are
any).
> * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the
source code (Babel and Eslint config files), and update them
appropriately.
> * Manually review
`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that
any CI pipeline customizations continue to be correctly applied after
the changed path names
> * Review all of the updated files, specially the `.ts` and `.js` files
listed in the sections below, as some of them contain relative paths
that have been updated.
> * Think of potential impact of the move, including tooling and
configuration files that can be pointing to the relocated modules. E.g.:
>     * customised eslint rules
>     * docs pointing to source code

> [!NOTE]
> * This PR has been auto-generated.
> * Any manual contributions will be lost if the 'relocate' script is
re-run.
> * Try to obtain the missing reviews / approvals before applying manual
fixes, and/or keep your changes in a .patch / git stash.
> * Please use
[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)
Slack channel for feedback.

Are you trying to rebase this PR to solve merge conflicts? Please follow
the steps describe
[here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E).

#### 1 packages(s) are going to be relocated:

| Id | Target folder |
| -- | ------------- |
| `@kbn/search-shared-ui` | `x-pack/solutions/search/packages/shared-ui`
|

<details >
<summary>Updated references</summary>

```
./package.json
./packages/kbn-relocate/utils/transforms.ts
./packages/kbn-ts-projects/config-paths.json
./src/platform/packages/private/kbn-repo-packages/package-map.json
./tsconfig.base.json
./x-pack/.i18nrc.json
./x-pack/solutions/search/packages/shared-ui/jest.config.js
./yarn.lock
.github/CODEOWNERS
```

</details><details >
<summary>Updated relative paths</summary>

```
x-pack/solutions/search/packages/shared-ui/jest.config.js:14
x-pack/solutions/search/packages/shared-ui/tsconfig.json:2
```

</details>

(cherry picked from commit 11cd98b)
  • Loading branch information
gsoldevila committed Feb 16, 2025
1 parent 884387a commit cab9bf3
Show file tree
Hide file tree
Showing 21 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -960,7 +960,7 @@ x-pack/solutions/search/packages/kbn-ipynb @elastic/search-kibana
x-pack/solutions/search/packages/kbn-search-api-keys-components @elastic/search-kibana
x-pack/solutions/search/packages/kbn-search-api-keys-server @elastic/search-kibana
x-pack/solutions/search/packages/kbn-search-index-documents @elastic/search-kibana
x-pack/solutions/search/packages/shared_ui @elastic/search-kibana
x-pack/solutions/search/packages/shared-ui @elastic/search-kibana
x-pack/solutions/search/plugins/enterprise_search @elastic/search-kibana
x-pack/solutions/search/plugins/search_assistant @elastic/search-kibana
x-pack/solutions/search/plugins/search_connectors @elastic/search-kibana
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -812,7 +812,7 @@
"@kbn/search-notebooks": "link:x-pack/solutions/search/plugins/search_notebooks",
"@kbn/search-playground": "link:x-pack/solutions/search/plugins/search_playground",
"@kbn/search-response-warnings": "link:src/platform/packages/shared/kbn-search-response-warnings",
"@kbn/search-shared-ui": "link:x-pack/solutions/search/packages/shared_ui",
"@kbn/search-shared-ui": "link:x-pack/solutions/search/packages/shared-ui",
"@kbn/search-synonyms": "link:x-pack/solutions/search/plugins/search_synonyms",
"@kbn/search-types": "link:src/platform/packages/shared/kbn-search-types",
"@kbn/searchprofiler-plugin": "link:x-pack/platform/plugins/shared/searchprofiler",
Expand Down
4 changes: 2 additions & 2 deletions tsconfig.base.json
Original file line number Diff line number Diff line change
Expand Up @@ -1614,8 +1614,8 @@
"@kbn/search-playground/*": ["x-pack/solutions/search/plugins/search_playground/*"],
"@kbn/search-response-warnings": ["src/platform/packages/shared/kbn-search-response-warnings"],
"@kbn/search-response-warnings/*": ["src/platform/packages/shared/kbn-search-response-warnings/*"],
"@kbn/search-shared-ui": ["x-pack/solutions/search/packages/shared_ui"],
"@kbn/search-shared-ui/*": ["x-pack/solutions/search/packages/shared_ui/*"],
"@kbn/search-shared-ui": ["x-pack/solutions/search/packages/shared-ui"],
"@kbn/search-shared-ui/*": ["x-pack/solutions/search/packages/shared-ui/*"],
"@kbn/search-synonyms": ["x-pack/solutions/search/plugins/search_synonyms"],
"@kbn/search-synonyms/*": ["x-pack/solutions/search/plugins/search_synonyms/*"],
"@kbn/search-types": ["src/platform/packages/shared/kbn-search-types"],
Expand Down
2 changes: 1 addition & 1 deletion x-pack/.i18nrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@
],
"xpack.runtimeFields": "platform/plugins/private/runtime_fields",
"xpack.screenshotting": "platform/plugins/shared/screenshotting",
"xpack.searchSharedUI": "solutions/search/packages/shared_ui",
"xpack.searchSharedUI": "solutions/search/packages/shared-ui",
"xpack.searchHomepage": "solutions/search/plugins/search_homepage",
"xpack.searchIndices": "solutions/search/plugins/search_indices",
"xpack.searchNavigation": "solutions/search/plugins/search_solution/search_navigation",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@

module.exports = {
coverageDirectory:
'<rootDir>/target/kibana-coverage/jest/x-pack/solutions/search/packages/shared_ui',
'<rootDir>/target/kibana-coverage/jest/x-pack/solutions/search/packages/shared-ui',
coverageReporters: ['text', 'html'],
collectCoverageFrom: ['<rootDir>/x-pack/solutions/search/packages/shared_ui/**/*.{ts,tsx}'],
collectCoverageFrom: ['<rootDir>/x-pack/solutions/search/packages/shared-ui/**/*.{ts,tsx}'],
preset: '@kbn/test',
rootDir: '../../../../..',
roots: ['<rootDir>/x-pack/solutions/search/packages/shared_ui'],
roots: ['<rootDir>/x-pack/solutions/search/packages/shared-ui'],
};
2 changes: 1 addition & 1 deletion yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -7097,7 +7097,7 @@
version "0.0.0"
uid ""

"@kbn/search-shared-ui@link:x-pack/solutions/search/packages/shared_ui":
"@kbn/search-shared-ui@link:x-pack/solutions/search/packages/shared-ui":
version "0.0.0"
uid ""

Expand Down

0 comments on commit cab9bf3

Please sign in to comment.