Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tempo] Add test coverage for Tempo queries #7671

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

josunect
Copy link
Contributor

Describe the change

Added test coverage for prepare query for query the Tempo API.

Steps to test the PR

Run new test tracing/tempo/http_client_test and verify it passes (Also run in CI)

Automation testing

Unit tests

Issue reference

Ref. #7658

@josunect josunect added the test: back-end/integration PR adds/updates back-end tests (unit and/or integration) label Aug 27, 2024
@josunect josunect self-assigned this Aug 27, 2024
@josunect josunect mentioned this pull request Aug 27, 2024
2 tasks
@josunect josunect marked this pull request as ready for review August 27, 2024 14:49
@josunect josunect requested a review from hhovsepy August 27, 2024 14:49
Copy link
Contributor

@hhovsepy hhovsepy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debugged locally.

@josunect josunect merged commit 83de72d into kiali:master Aug 28, 2024
10 checks passed
@josunect josunect deleted the issue7658_test_coverage branch August 28, 2024 08:03
jshaughn pushed a commit to jshaughn/kiali that referenced this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test: back-end/integration PR adds/updates back-end tests (unit and/or integration)
Projects
Development

Successfully merging this pull request may close these issues.

2 participants