Bump github.com/prometheus/client_golang from 1.20.2 to 1.20.5 #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.20.2 to 1.20.5. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.20.2...v1.20.5) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Reviewer's Guide by SourceryThis PR bumps the version of github.com/prometheus/client_golang from v1.20.2 to v1.20.5. This addresses a bug in the testutil package where functions using compareMetricFamilies were failing if filtered metricNames were present in the expected input. It also includes fixes for data races that could occur when appending exemplars to histograms. Sequence diagram showing the fixed data race in histogram exemplar handlingsequenceDiagram
participant H as Histogram
participant M as Metrics Gatherer
participant E as Exemplar Handler
Note over H,E: Before fix: Potential data race
par Concurrent operations
M->>H: Gather metrics
E->>H: Append exemplar
end
Note over H,E: After fix: Protected concurrent access
par Fixed concurrent operations
M->>H: Gather metrics (protected)
E->>H: Append exemplar (protected)
end
Class diagram showing the testutil package changesclassDiagram
class TestUtil {
+compareMetricFamilies(expected, actual, metricNames)
}
note for TestUtil "v1.20.5: Reverted behavior change.
Now only fails if filtered metricNames
are in expected input"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Note Free review on us!CodeRabbit is offering free reviews until Wed Jan 15 2025 to showcase some of the refinements we've made. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
CI Failure Feedback 🧐(Checks updated until commit 075c56a)
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR: where Configuration options
See more information about the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps github.com/prometheus/client_golang from 1.20.2 to 1.20.5.
Release notes
Sourced from github.com/prometheus/client_golang's releases.
Changelog
Sourced from github.com/prometheus/client_golang's changelog.
Commits
48e12a1Merge pull request #1645 from prometheus/cut-1204-pr1424504ad9bCut 1.20.5; update comments.584a7ceRevert "testutil compareMetricFamilies: make less error-prone (#1424)"05fcde9Merge pull request #1623 from krajorama/data-race-in-histogram-write209f4c0Add changelog1e398ccnative histogram: Fix race between Write and addExemplaref2f87eMerge pull request #1620 from prometheus/arthursens/prepare-1.20.3937ac63Add changelog entry for 1.20.36e9914dMerge pull request #1608 from krajorama/index-out-of-range-native-histogram-e...d6b8c89Update comments with more explanationsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Summary by Sourcery
Update github.com/prometheus/client_golang from 1.20.2 to 1.20.5. This includes a fix for a possible data race when appending exemplars, and reverts a change to the testutil package that caused issues for downstream users.
Bug Fixes: