Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to set "externalTrafficPolicy" in "GatewayParameters" #9879

Open
heruscode opened this issue Aug 9, 2024 · 3 comments · Fixed by solo-io/gloo#10420
Open

Ability to set "externalTrafficPolicy" in "GatewayParameters" #9879

heruscode opened this issue Aug 9, 2024 · 3 comments · Fixed by solo-io/gloo#10420
Assignees
Labels
Area: K8S Gateway API Issues related to the Kubernetes Gateway API release/1.18 Type: Enhancement New feature or request

Comments

@heruscode
Copy link

heruscode commented Aug 9, 2024

Gloo Edge Product

Open Source

Gloo Edge Version

1.17

Is your feature request related to a problem? Please describe.

I am using Gloo Gateway 1.17 and trying to setup externalTrafficPolicy: "Local" in a custom GatewayParameters object (since I am using GCP’s GKE, I need to preserve the original client IP address in the Service/LoadBalancer)

it seems like spec.kube.service.externalTrafficPolicy is currently not supported in GatewayParameters

Describe the solution you'd like

GatewayParameters resource should support spec.kube.service.externalTrafficPolicy

Describe alternatives you've considered

No response

Additional Context

No response

┆Issue is synchronized with this Asana task by Unito

@heruscode heruscode added the Type: Enhancement New feature or request label Aug 9, 2024
@sam-heilbron sam-heilbron added release/1.17 release/1.18 Area: K8S Gateway API Issues related to the Kubernetes Gateway API labels Aug 9, 2024
@bgroupe
Copy link

bgroupe commented Sep 12, 2024

@sam-heilbron will this be addressed in an upcoming release?

@sam-heilbron
Copy link
Contributor

@sam-heilbron will this be addressed in an upcoming release?

Sorry for the delay in getting back to you. We have an open PR to introduce this functionality: solo-io#10420.

As it stands right now, we are not considering this a release blocker to our 1.18.0 release which is targeted for a week from now. However, we intend to merge this shortly after, and have it available in a 1.19.0-beta1. Would that be reasonable?

@bgroupe
Copy link

bgroupe commented Dec 4, 2024

@sam-heilbron will this be addressed in an upcoming release?

Sorry for the delay in getting back to you. We have an open PR to introduce this functionality: solo-io#10420.

As it stands right now, we are not considering this a release blocker to our 1.18.0 release which is targeted for a week from now. However, we intend to merge this shortly after, and have it available in a 1.19.0-beta1. Would that be reasonable?

sure, I just saw the activity on the issue but no comments. not pressing at the moment, but good to know it will be added. cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: K8S Gateway API Issues related to the Kubernetes Gateway API release/1.18 Type: Enhancement New feature or request
Projects
None yet
5 participants