Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create mechanism to inject helm settings in e2e tests #10374

Open
sheidkamp opened this issue Nov 22, 2024 · 3 comments
Open

Create mechanism to inject helm settings in e2e tests #10374

sheidkamp opened this issue Nov 22, 2024 · 3 comments

Comments

@sheidkamp
Copy link
Contributor

Do you have a suggestion for code improvement or tracking existing technical debt? Please describe.

The Split Webhook Validation tests rely on a testhelper to run Helm commands to update the gloo install.

More tests may need to do this in the future.

Currently these types of tests can not be run from other projects that import k8sgateway as a dependency.

For the moment, a separate SuiteRunner has been created for this situation.

Describe the solution you'd like

Create a way to pass a testhelper/helm values root to the tests.

Additional Context

No response

@sam-heilbron
Copy link
Contributor

Something to keep in mind when we solve this:

https://github.com/solo-io/gloo/blob/e2ca0280c1828c5a7131d5e4c398770fc279088c/test/kubernetes/e2e/test.go#L25: The testHelper is a wrapper around glooctl, that we had used because it existed and allowed us to avoid rebuilding a tool. However, we know it has limitations, and would rather rely on the CLI directly if possible, to avoid building logic into our tests that our customers can't used

@sheidkamp
Copy link
Contributor Author

There is a suggested approach here, to add the testhelper to the TestInstallation, which would be solve half of the issue.

The TestInstallation may be a good place to specify a Helm prefix as well

@sheidkamp
Copy link
Contributor Author

ashishb-solo pushed a commit to ashishb-solo/k8sgateway that referenced this issue Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants