Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding graphmap section #154

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

adding graphmap section #154

wants to merge 2 commits into from

Conversation

dachafra
Copy link
Member

Adaptation of R2RML section for graphsMaps:

  1. Includes the possibility to generate graph-maps with BN Generate graphs with blank node graph name #146
  2. Adds a new example on how to generate BN in POMs

@dachafra dachafra requested a review from pmaria January 23, 2025 16:29
Copy link
Collaborator

@pmaria pmaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make sure that the definition references work where possible [=defenition-recerence=] and introduce definitions where necessary, e.g. for graph map: <dfn>graph map</dfn>.


Each triple generated from an [=RML mapping=]() is placed into one or more graphs of the [=output dataset=](). Possible target graphs are the unnamed [=default graph=](), the [=IRI=]()-named [=named graphs=](), and [=blank node=]() named [=named graphs=]()

Any [=subject map=]() or [=predicate-object=]() map MAY have one or more associated graph maps. They are specified in one of two ways:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Any [=subject map=]() or [=predicate-object=]() map MAY have one or more associated graph maps. They are specified in one of two ways:
Any [=subject map=]() or [=predicate-object=]() map MUST have zero or more associated graph maps. They are specified in one of two ways:

@@ -106,6 +106,8 @@

<section id="joins" data-include="joinconditions.md" data-include-format="markdown"></section>

<section id="graphmaps" data-include="graphmaps.md" data-include-format="markdown"></section>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<section id="graphmaps" data-include="graphmaps.md" data-include-format="markdown"></section>
<section id="graphmaps" data-include="graphmap.md" data-include-format="markdown"></section>

Comment on lines +16 to +21
```turtle
[] rml:subjectMap [
rml:template "http://data.example.com/department/{DEPTNO}";
rml:graphMap [ rml:constant ex:DepartmentGraph ];
].
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Examples should be formatted like other examples in spec. Using <aside ...>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants