Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define logical source in core and add spec refs #141

Merged
merged 5 commits into from
Aug 7, 2024
Merged

Conversation

pmaria
Copy link
Collaborator

@pmaria pmaria commented Aug 1, 2024

No description provided.

@pmaria pmaria requested a review from andimou August 1, 2024 10:08
@@ -0,0 +1,11 @@
# Defining Logical Sources

A <dfn>logical source</dfn> is a function on a [=data source=] that provides data to be mapped to [=RDF triples=].
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it actually a function?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah maybe we need to define it more abstractly. How would you define it?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A Logical Source is an abstract description for describing data access and iteration of a data source which is mapped to RDF quads.

  • Logical Source is a term -> caps
  • RDF quads -> triples implies no Named Graph support

WDYT?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A Logical Source is an abstract description for describing data access and iteration of a data source which is mapped to RDF quads.

I then suggest:

Suggested change
A <dfn>logical source</dfn> is a function on a [=data source=] that provides data to be mapped to [=RDF triples=].
A <dfn>logical source</dfn> is an abstract construct to describe data access and iteration for a [=data source=] such that it can be mapped to [=RDF triples=].
  • Logical Source is a term -> caps

I prefer to keep it lower case, but have all occurrences of terms linked to the definitions. Otherwise there will be a lot of caps in sentences, which IMO does not aid readability

  • RDF quads -> triples implies no Named Graph support

I know @andimou wants to keep the text close to the R2RML rec. There the term RDF triple is used throughout. Also, I'm not sure there is an authorative definition of quad anywhere in the W3C recs.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the suggested change! The word 'function' is tricky as it might confuse people with rml-fnml.

I prefer to keep it lower case, but have all occurrences of terms linked to the definitions.

That's something we need to align across all specs. RML-IO prefers caps when it talks about classes like Logical Source, following the practices used in ontologies.

There the term RDF triple is used throughout.

Yeah that's fine for me as well, aligns with Triples Maps though.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's something we need to align across all specs. RML-IO prefers caps when it talks about classes like Logical Source, following the practices used in ontologies.

OK. Core is quite heavy on definitions and references to defined terms. So I think it's more of an issue there.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if we can coordinate across all specs the same approach to not confuse readers?

spec/docs/logicalSource.md Show resolved Hide resolved
@pmaria pmaria requested a review from DylanVanAssche August 7, 2024 10:42
@pmaria pmaria merged commit 61d115b into main Aug 7, 2024
1 check passed
@pmaria pmaria deleted the 127-logical-source branch August 7, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants