Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: RMLTC0002c-JSON & RMLTC0002c-XML (bis) #101

Closed
chrdebru opened this issue Feb 25, 2024 · 2 comments
Closed

RFC: RMLTC0002c-JSON & RMLTC0002c-XML (bis) #101

chrdebru opened this issue Feb 25, 2024 · 2 comments
Assignees
@DylanVanAssche
Labels
bug Something isn't working

Comments

@chrdebru
Copy link
Collaborator

As @pmaria pointed out in kg-construct/rml-test-cases#12, some tests should be removed for JSON and XML.
@DylanVanAssche
Copy link
Collaborator

Agreed! Key values are optional in these cases.

DylanVanAssche added a commit that referenced this issue Feb 29, 2024
@DylanVanAssche
RMLTC0002c-{XML,JSON}: remove
75c97a5 
Key values are optional in XML and JSON.
Engines should not fail if a key is not present in an XML or JSON
document like they should with tabular data like SQL or CSV.

Fixes #101
@DylanVanAssche
Copy link
Collaborator

Made a fix in #105

@DylanVanAssche DylanVanAssche added the bug Something isn't working label Feb 29, 2024
@DylanVanAssche DylanVanAssche self-assigned this Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DylanVanAssche DylanVanAssche

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DylanVanAssche @chrdebru