Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LineaStatebridge #51

Closed
wants to merge 5 commits into from
Closed

LineaStatebridge #51

wants to merge 5 commits into from

Conversation

Jemiiah
Copy link
Contributor

@Jemiiah Jemiiah commented Aug 25, 2024

issue: #4
creating a comprehensive end-to-end test for the entire World ID state bridge system. to ensure that all components work together correctly and that the cross-chain functionality operates as expected.

@Jemiiah
Copy link
Contributor Author

Jemiiah commented Aug 26, 2024

still working on a few things

@kfastov
Copy link
Owner

kfastov commented Aug 26, 2024

Hey @Jemiiah ! Sorry for ruining your previous PR, I just thought you abandoned it and I wanted to merge the tests quickly and failed. Thanks for working on it!

@Jemiiah
Copy link
Contributor Author

Jemiiah commented Aug 27, 2024

thank you @kfastov it's no problem ser thanks on the patience

@kfastov
Copy link
Owner

kfastov commented Aug 27, 2024

@Jemiiah Can I help you somehow btw? No pressure, but we need these tests for the audit, so I want to do everything I can to help you 😅

@Jemiiah
Copy link
Contributor Author

Jemiiah commented Aug 27, 2024

@kfastov thanks man again for your patience so what is left is replicating the linearworldID contract test which would be sorted out soon chief 🫡

remappings.txt Outdated
@prb/test/=node_modules/@prb/test/src/
@eth-optimism/=node_modules/@eth-optimism/
@worldcoin/=node_modules/@worldcoin/
hardhat/=node_modules/hardhat/
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need Hardhat btw? I haven't found any Hardhat or HRE mentions in your tests yet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by bad took care of it @kfastov

@kfastov
Copy link
Owner

kfastov commented Aug 27, 2024

@Jemiiah Sounds great. Looking forward to it 👍

@Jemiiah Jemiiah marked this pull request as ready for review August 29, 2024 16:08
@Jemiiah
Copy link
Contributor Author

Jemiiah commented Aug 29, 2024

@kfastov you can take a look now ser

@kfastov
Copy link
Owner

kfastov commented Aug 31, 2024

Hi @Jemiiah can you fix lint and build please?

@Jemiiah Jemiiah closed this by deleting the head repository Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants