Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implemented the LineaWorldID and Modifier functionality #10

Merged
merged 3 commits into from
Jul 2, 2024

Conversation

0xprinc
Copy link
Contributor

@0xprinc 0xprinc commented Jun 28, 2024

I have followed this documentation as used in issue #1

Updated contracts :

  • LineaWorldID.sol
    • Replaced CrossDomainOwnable3 with MessageServiceBase to apply caller modifier, as mentioned in Linea Messaging docs
    • Replaced onlyOwner modifier with onlyMessagingService and onlyAuthorizedRemoteSender as provided by MessageServiceBase
    • Added updateMessageServiceBase to update Authorised addresses
  • Added MessageServiceBase(contains new modifiers), IMessageService(dependency for MessageServiceBase), ILineaWorldID(dependency of LineaWorldId)

@KodeSage
Copy link
Contributor

Hi @0xprinc , do forge fmt to lint the code well.

@kfastov
Copy link
Owner

kfastov commented Jul 2, 2024

@0xprinc Looks good overall. Thank you very much for your contribution!

@kfastov kfastov merged commit 7ccd041 into kfastov:main Jul 2, 2024
3 checks passed
@kfastov kfastov linked an issue Jul 4, 2024 that may be closed by this pull request
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev: add World ID contract for Linea
3 participants