Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/{send_kcidb,logspec_api}: add suport for kselftest #996

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

helen-fornazier
Copy link
Contributor

In logspec_api, rename object_type to test_type, which are the supported types it can parse.

In send_kcidb, extract the test_type from the node.

Add kselftest to the list of types it supports.

In logspec_api, rename object_type to test_type, which are the supported
types it can parse.

In send_kcidb, extract the test_type from the node.

Add kselftest to the list of types it supports.

Signed-off-by: Helen Koike <helen.koike@collabora.com>
Copy link
Contributor

@pawiecz pawiecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch set looks good 👍

My personal preference would be to leave object_type as it is since it covers "build" Nodes as well but let's keep this PR as it is (reverting this rename is just a sed away if there are more non-test object types in the future)

@padovan
Copy link
Contributor

padovan commented Feb 6, 2025

@helen-fornazier do you have an example of issue generated by this?

@helen-fornazier
Copy link
Contributor Author

@helen-fornazier do you have an example of issue generated by this?

Yes: https://grafana.kernelci.org/d/issue/issue?var-datasource=edqupth5xi8e8b&var-id=maestro:346385016734add8169277c19da9a21b9d7fb1e2

Also, I just tested it and it seems to be working, I'm removing the Draft

@helen-fornazier helen-fornazier marked this pull request as ready for review February 6, 2025 13:40
@nuclearcat nuclearcat added this pull request to the merge queue Feb 10, 2025
Merged via the queue into kernelci:main with commit 38aed5c Feb 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants