-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: chromeos: Add ChromiumOS tree and Clang kbuild jobs #995
base: main
Are you sure you want to change the base?
Conversation
Please remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I assume you tested the chromeos branch with Clang 17 :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, it could be a bit more concise but there's nothing wrong with the current implementation.
config/jobs-chromeos.yaml
Outdated
tree: | ||
- chromiumos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tree: | |
- chromiumos | |
<<: *kbuild-clang-17-arm64-chromeos-rules |
Thanks for the feedback - I'll apply the fixes as suggested. |
91422e4
to
0e8a9b9
Compare
Add the ChromiumOS kernel tree (branches 5.4 to 6.12) and define new Clang kbuild jobs for both ARM64 and x86_64 Chromebooks. Signed-off-by: Laura Nao <laura.nao@collabora.com>
I ran just one manual LAVA job with a chromeos-6.12 build w/ Clang 17 (build was successful and boots) - see https://lava.collabora.dev/scheduler/job/17616230 for reference I'll wait for the staging results to confirm if the other branches built successfully. |
Add the ChromiumOS kernel tree (branches 5.4 to 6.12) and define new Clang kbuild jobs for both ARM64 and x86_64 Chromebooks.