Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable wifi-basic test on the Genio 700 EVK #975

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Enable wifi-basic test on the Genio 700 EVK #975

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
25991a5
config: pipeline: Add build job for arm64 with arm64-chromebook fragment
nfraprado Jan 24, 2025
60f047a
config: pipeline: Add wifi-basic job definition
nfraprado Jan 24, 2025
103bc20
config: pipeline: Run wifi-basic test on the Genio 700 EVK
nfraprado Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions config/pipeline.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -926,6 +926,15 @@ jobs:

kbuild-gcc-12-arm64: *kbuild-gcc-12-arm64-job

kbuild-gcc-12-arm64-chromebook-main:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would make sense to me to have this one a plain "-chromebook" and the other one "-chromeos" (since it's in "*-chromeos.yaml" configs).

We can merge it as it is and do the rename as a next step (here, in jobs- and scheduler- files).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that sounds fine to me. I wanted to keep this PR contained to pipeline.yaml and so I preferred doing the name change here. But renaming the chromeos ones in a separate PR sounds good.

<<: *kbuild-gcc-12-arm64-job
params:
<<: *kbuild-gcc-12-arm64-params
fragments:
- 'lab-setup'
- 'kselftest'
- 'arm64-chromebook'

kbuild-gcc-12-arm64-allnoconfig:
<<: *kbuild-gcc-12-arm64-job
params:
Expand Down Expand Up @@ -1886,6 +1895,19 @@ jobs:
- media
kcidb_test_suite: h26forge.debian

wifi-basic:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This job definition is not anchored anywhere in the main file - did you encounter any failures in processing scheduler entries with this job definition when it's read from "jobs-chromeos.yaml"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not set up to run the kci tools here, so I'm relying on the CI checks done in github.

My understanding is that the anchors are private to the yaml file. In jobs-chromeos.yaml the only wifi-basic entry is in the anchors, so it is not visible from the pipeline.yaml, hence there are no conflicts. I think that's what you were asking, but let me know otherwise.

template: generic.jinja2
kind: job
params:
test_method: wifi-basic
boot_commands: nfs
nfsroot: 'https://storage.kernelci.org/images/rootfs/debian/bookworm-wifi/20240313.0/{debarch}/'
rules:
tree:
- mainline
- stable-rc
kcidb_test_suite: kernelci_wifi_basic

trees:

amlogic:
Expand Down Expand Up @@ -2282,6 +2304,14 @@ scheduler:
- rk3588-rock-5b
- sun50i-h6-pine-h64

- job: wifi-basic
event:
<<: *node-event-kbuild
name: kbuild-gcc-12-arm64-chromebook-main
runtime: *lava-collabora-runtime
platforms:
- mt8390-genio-700-evk

- job: baseline-arm64-android
event:
<<: *node-event-kbuild
Expand Down