-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add global config #42
Conversation
docs/index.md
Outdated
@@ -16,7 +16,9 @@ poetry run kci-dev | |||
|
|||
## Configuration | |||
|
|||
kci-dev uses a configuration file .kci-dev.toml in the program directory. | |||
kci-dev uses a configuration file .kci-dev.toml in the current program directory | |||
or global configuration directory, in user's home directory/.config/kci-dev.toml. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about to use something like "$HOME/.config/kci-dev/kci-dev.toml"
so that we can have a subdirectory under .config for kci-dev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also this is not a global configuration but a USER configuration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
global configurations are under /etc/ in most OS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
current program directory configuration ".kci-dev.toml" is per SITE configuration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and loading order is generally
- Global
- User
- Site
- kci-dev settings options
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, i will update. About loading order, do you mean "site" for example override previous ones or global have highest priority and will be used as highest priority (if available)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each file read overrides any values read from previous files
site for example override previous ones
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i also added the kci-dev settings options in the list
any update on this? |
We can have local config file .kci-dev.toml, but also we should have global config, so we can operate in any directory, as any similar program. Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
As we can have local config and "global" config, we should document that. Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
47538ea
to
e25a0b7
Compare
While doing global settings change due bad internet connection i reversed to old version by mistake. This will fix kernelci#42 and make it work as intended. Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
While doing global settings change due bad internet connection i reversed to old version by mistake. This will fix kernelci#42 and make it work as intended. Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
Implement support for a global configuration file to enable kci-dev functionality across any source directory location, but keep support of local configuration file. This enhancement will allow for more flexible project setup and improved workflow portability.