make 'results' subcommand more useful #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This python code was just an experiment that got merged by mistake through some git add/commit. Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>
We asked the Dashboard team to make the endpoints easier to access, so they split them up for us. Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>
Make it consistent with the name of the other fetch functions. Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>
Enable users to see test results through kci-dev. The json structure is the same as builds, so this reuses the same function, renaming it to 'cmd_tests'. Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>
Create a filter file to specify the hardware you want to see in the results. It uses a yaml file: --- hardware: - radxa,rock2-square - fsl,imx6q - dell-latitude-3445-7520c-skyrim --- The filter file can be expanded to other characteristics as we evolve the tool. Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>
It broke during the recent refactor to enable tests results. Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>
Adding info about boots, tests and hardware filter. Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>
aliceinwire
reviewed
Jan 23, 2025
| @@ -12,13 +12,14 @@ | |||
|
|
|||
| import click | |||
| import requests | |||
| import yaml | |||
There was a problem hiding this comment.
This package is already using toml, is possible to use toml also for filtering?
I would prefer keep the dependency at minimum for more easy distribution packaging and dependency requirements
There was a problem hiding this comment.
I don' t really thing toml is a good idea for this kind of filter. YAML is pretty straightforward to write for a our users.
aliceinwire
reviewed
Jan 23, 2025
|
|
||
|
|
||
| def cmd_tests(data, commit, download_logs, status_filter, filter): | ||
| filter_data = yaml.safe_load(filter) if filter else None |
There was a problem hiding this comment.
this should be converted to toml
aliceinwire
reviewed
Jan 23, 2025
| @@ -1,53 +0,0 @@ | |||
| import click | |||
There was a problem hiding this comment.
Thanks, for removing this
|
looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand support beyond builds for boots and tests results. Also also bring in a hardware filter feature for the boot and tests results plus a few other visualization improvements.